-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ValidateDiscoverableLogin hides handler error #140
Labels
Comments
leejuyuu
added
status/needs-triage
Issues that need to be triaged.
type/potential-bug
Potential Bugs
labels
May 29, 2023
james-d-elliott
added a commit
that referenced
this issue
Jun 19, 2023
This exposes the underlying error as a string. There needs to be some additional work in this area regardless as the idea would be to wrap the error but the current implementation doesn't explicitly implement this. Fixes #140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Version
0.8.2
Description
The
ValidateDiscoverableLogin
method masks the underlying error message returned byDiscoverableUserHandler
, which makes troubleshooting harder. Please consider methods like wrapping the error to allow the source problem to be exposed.Reproduction
Run the following
code
The terminal will print something like
which does not reveal the cause of the error.
Expectations
Maybe wrapping the error like
Documentation
No response
The text was updated successfully, but these errors were encountered: