From 50e679546ddf93b4965de1a500e4254953b00f5a Mon Sep 17 00:00:00 2001 From: jennifersp Date: Tue, 28 Nov 2023 16:30:32 -0800 Subject: [PATCH 1/3] fix for enum and set field type to column type conversion --- fields.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fields.go b/fields.go index 30f31cbfb..2a397b245 100644 --- a/fields.go +++ b/fields.go @@ -77,6 +77,11 @@ func (mf *mysqlField) typeDatabaseName() string { } return "SMALLINT" case fieldTypeString: + if mf.flags&flagEnum != 0 { + return "ENUM" + } else if mf.flags&flagSet != 0 { + return "SET" + } if mf.charSet == binaryCollationID { return "BINARY" } From fd55af3188e8e27b259c3db5f85e10780f50f111 Mon Sep 17 00:00:00 2001 From: jennifersp Date: Wed, 6 Dec 2023 10:11:42 -0800 Subject: [PATCH 2/3] update AUTHORS file --- AUTHORS | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/AUTHORS b/AUTHORS index 2caa7d706..12e4c610d 100644 --- a/AUTHORS +++ b/AUTHORS @@ -21,6 +21,7 @@ Animesh Ray Arne Hormann Ariel Mashraki Asta Xie +Brian Hendriks Bulat Gaifullin Caine Jette Carlos Nieto @@ -54,6 +55,7 @@ Jason Ng Jean-Yves Pellé Jeff Hodges Jeffrey Charles +Jennifer Purevsuren Jerome Meyer Jiajia Zhong Jian Zhen @@ -115,13 +117,13 @@ Zhang Xiang Zhenye Xie Zhixin Wen Ziheng Lyu -Brian Hendriks # Organizations Barracuda Networks, Inc. Counting Ltd. DigitalOcean Inc. +Dolthub Inc. dyves labs AG Facebook Inc. GitHub Inc. @@ -135,4 +137,3 @@ Pivotal Inc. Shattered Silicon Ltd. Stripe Inc. Zendesk Inc. -Dolthub Inc. From 8e7cd6d2886302cc4542ac4c272af5d8a6badefe Mon Sep 17 00:00:00 2001 From: jennifersp Date: Tue, 12 Dec 2023 11:59:24 -0800 Subject: [PATCH 3/3] add test --- driver_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/driver_test.go b/driver_test.go index efbff1792..8635ad647 100644 --- a/driver_test.go +++ b/driver_test.go @@ -3004,6 +3004,8 @@ func TestRowsColumnTypes(t *testing.T) { {"datetime6", "DATETIME(6)", "DATETIME", scanTypeNullTime, true, 6, 6, [3]string{"'2006-01-02 15:04:05'", "'2006-01-02 15:04:05.1'", "'2006-01-02 15:04:05.111111'"}, [3]interface{}{nt0, nt1, nt6}}, {"date", "DATE", "DATE", scanTypeNullTime, true, 0, 0, [3]string{"'2006-01-02'", "NULL", "'2006-03-04'"}, [3]interface{}{nd1, ndNULL, nd2}}, {"year", "YEAR NOT NULL", "YEAR", scanTypeUint16, false, 0, 0, [3]string{"2006", "2000", "1994"}, [3]interface{}{uint16(2006), uint16(2000), uint16(1994)}}, + {"enum", "ENUM('', 'v1', 'v2')", "ENUM", scanTypeNullString, true, 0, 0, [3]string{"''", "'v1'", "'v2'"}, [3]interface{}{ns(""), ns("v1"), ns("v2")}}, + {"set", "set('', 'v1', 'v2')", "SET", scanTypeNullString, true, 0, 0, [3]string{"''", "'v1'", "'v1,v2'"}, [3]interface{}{ns(""), ns("v1"), ns("v1,v2")}}, } schema := ""