Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quotes are not well rendered in archives #950

Closed
romu70 opened this issue Jul 3, 2024 · 2 comments · Fixed by #951
Closed

Quotes are not well rendered in archives #950

romu70 opened this issue Jul 3, 2024 · 2 comments · Fixed by #951
Assignees
@Monirzadeh
Labels
component:frontend The bug is in front-end type:bug Something isn't working

Comments

@romu70
Copy link

romu70 commented Jul 3, 2024

Data

  • Shiori version: 1.7.0
  • Database Engine: Postgre
  • Operating system: Docker
  • CLI/Web interface/Web Extension:

Describe the bug / actual behavior

markup

text of the quote

Quote author

Quote rendered in the original article

Screenshot 2024-07-03 at 11 47 02

Quote rendered by Shiori

Screenshot 2024-07-03 at 11 49 01

Expected behavior

Quotes should be clearly rendered as...quotes and not like being part of the text.

To Reproduce

Steps to reproduce the behavior:

  1. Archive a link which has quotes
  2. Open it
@romu70 romu70 added the type:bug Something isn't working label Jul 3, 2024
@Monirzadeh
Copy link
Collaborator

you mean readable version not archive right?
can you please add some site for example that you can't see quote correctly on them.

@romu70
Copy link
Author

romu70 commented Jul 3, 2024

Sure.
Here is the link of the particular example:
https://legrandcontinent.eu/fr/2024/07/01/rassemblement-national-genealogie-dune-ascension-avec-olivier-roy-ivanne-trippenbach-et-felicien-faury/

@Monirzadeh Monirzadeh added component:frontend The bug is in front-end and removed component:readability labels Jul 3, 2024
@Monirzadeh Monirzadeh self-assigned this Jul 3, 2024
@Monirzadeh Monirzadeh mentioned this issue Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Monirzadeh Monirzadeh

Labels
component:frontend The bug is in front-end type:bug Something isn't working
Projects
Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: better style for quotes Monirzadeh/shiori
2 participants
@romu70 @Monirzadeh