Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify datetime manipulation for the multiple database engines #909

Open
fmartingr opened this issue May 15, 2024 · 0 comments
Open

Unify datetime manipulation for the multiple database engines #909

fmartingr opened this issue May 15, 2024 · 0 comments
Labels

Comments

@fmartingr
Copy link
Member

Data

  • Shiori version: 1.6.3+ and potentially all older versions
  • Database Engine: All
  • Operating system: Not aplicable
  • CLI/Web interface/Web Extension: Not aplicable

Describe the bug / actual behavior

Having multiple database engines means storing data in potentially different data types. That's the case with the datetime datatype. We store it differently for each database engine, returning different results in the API.

We need to add a layer of abstraction on our database or DTO structs so that the API returns the same datetime format.

We need to take into consideration that every datetime in database is UTC, since SQLite for example uses a string to store the datetimes (it does not have any time specific datatype).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To do
Development

No branches or pull requests

1 participant