Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with image display in Chrome v1.6.0-rc.7 #857

Open
DesarrolloAntonio opened this issue Mar 12, 2024 · 2 comments · May be fixed by #858
Open

Issue with image display in Chrome v1.6.0-rc.7 #857

DesarrolloAntonio opened this issue Mar 12, 2024 · 2 comments · May be fixed by #858
Assignees
Labels
type:bug Something isn't working
Milestone

Comments

@DesarrolloAntonio
Copy link

DesarrolloAntonio commented Mar 12, 2024

Problem Description

I am experiencing an issue with the display of images in the Shiori app when using Google Chrome. I'm currently testing with version v1.6.0-rc.7 of Shiori.

Steps to Reproduce

  1. Create several bookmarks in the app.
  2. Delete all the created bookmarks.
  3. Add several bookmarks again.
  4. Open the app in an incognito tab on the left and a normal tab on the right (See capture)
  5. Observe that on the right tab, only one image is displayed correctly.

Captura de pantalla_área-de-selección_20240312164127

Edit: I've also noticed that this issue occasionally occurs in incognito mode as well.

image

@DesarrolloAntonio DesarrolloAntonio added the type:bug Something isn't working label Mar 12, 2024
@Monirzadeh
Copy link
Collaborator

Monirzadeh commented Mar 14, 2024

hi i test that it happen just when i use refresh in shiori and if i use ctrl + F5 it fix.
somehow refresh can't clean cache of browser but i don't find why it happen for some of bookmark yet
@fmartingr do you have any idea?

update: i test that in firefox.

update:
change this part

thumbnailStyleURL() {
return {
backgroundImage: `url("${this.imageURL}")`,
};
},

to somthing like this solve problem in my tests

thumbnailStyleURL() {
    const cacheBuster = new Date().getTime(); // Unique timestamp
    const thumbnailWithCacheBuster = `${this.imageURL}?cache=${cacheBuster}`;
    return {
        backgroundImage: `url("${thumbnailWithCacheBuster}")`,
    };
},

what do you think? any better solution?
if it is fine to you send i will send a PR to fix that.

@DesarrolloAntonio can you test this on your system and report if problem will solve with this change for you too?

@DesarrolloAntonio
Copy link
Author

hi i test that it happen just when i use refresh in shiori and if i use ctrl + F5 it fix. somehow refresh can't clean cache of browser but i don't find why it happen for some of bookmark yet @fmartingr do you have any idea?

update: i test that in firefox.

update: change this part

thumbnailStyleURL() {
return {
backgroundImage: `url("${this.imageURL}")`,
};
},

to somthing like this solve problem in my tests

thumbnailStyleURL() {
    const cacheBuster = new Date().getTime(); // Unique timestamp
    const thumbnailWithCacheBuster = `${this.imageURL}?cache=${cacheBuster}`;
    return {
        backgroundImage: `url("${thumbnailWithCacheBuster}")`,
    };
},

what do you think? any better solution? if it is fine to you send i will send a PR to fix that.

@DesarrolloAntonio can you test this on your system and report if problem will solve with this change for you too?

In the Android app PageKeeper, I fixed it with a similar solution, but instead of a timestamp, I added the "modified" field.

// Append 'lastUpdated' query to image URL for cache busting. Forces retrieval of updated images.
val imageUrl = "${serverURL.removeTrailingSlash()}${bookmark.imageURL}?lastUpdated=${bookmark.modified}"

Monirzadeh added a commit to Monirzadeh/shiori that referenced this issue Mar 15, 2024
@fmartingr fmartingr added this to the 1.8.0 milestone May 18, 2024
@Monirzadeh Monirzadeh self-assigned this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
Status: To do
Development

Successfully merging a pull request may close this issue.

3 participants