Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start page bug #788

Open
LLKoder opened this issue Nov 27, 2023 · 3 comments
Open

Start page bug #788

LLKoder opened this issue Nov 27, 2023 · 3 comments
Labels
type:bug Something isn't working

Comments

@LLKoder
Copy link
Contributor

LLKoder commented Nov 27, 2023

Data

  • Shiori version: lastest
  • Database Engine: sqlite
  • Operating system: linux
  • CLI/Web interface/Web Extension: Web interface

Describe the bug / actual behavior

When I first open browser with Shiori I see error:

Error - Session has expired, please login again.

...instead login page.

If I click 'OK' it relocate me to login page, but why do I get error when I first open browser without any cookies?

2023-11-27_15-35

@LLKoder LLKoder added the type:bug Something isn't working label Nov 27, 2023
@Monirzadeh
Copy link
Collaborator

it show error because it can't find cookies that needed.
@fmartingr can we redirect without show error or automatically redirect after 3 second (or at least if user open root?)
currently it is a little confusing.

@LLKoder
Copy link
Contributor Author

LLKoder commented Nov 27, 2023

it show error because it can't find cookies that needed.

Yep, I said about this. Why show this error if users open this page first times. I understand if it show me in second, .. etc, but first times. I have not been even login Shiori at all.

@fmartingr
Copy link
Member

This happens because the error logic in the frontend is centralised in a single place, that means that for any error that the API returns we show the error dialog. I agree that the best UX here would be to redirect to login directly, and if the user tried to access a page directly show a "You are not logged in, please authenticate" message in the login page. After login in, the user will get redirected to the page that was trying to open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

3 participants