-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start page bug #788
Comments
it show error because it can't find cookies that needed. |
Yep, I said about this. Why show this error if users open this page first times. I understand if it show me in second, .. etc, but first times. I have not been even login Shiori at all. |
This happens because the error logic in the frontend is centralised in a single place, that means that for any error that the API returns we show the error dialog. I agree that the best UX here would be to redirect to login directly, and if the user tried to access a page directly show a "You are not logged in, please authenticate" message in the login page. After login in, the user will get redirected to the page that was trying to open. |
Data
Describe the bug / actual behavior
When I first open browser with Shiori I see error:
Error - Session has expired, please login again.
...instead login page.
If I click 'OK' it relocate me to login page, but why do I get error when I first open browser without any cookies?
The text was updated successfully, but these errors were encountered: