Switch to prefix search for bookmarks #741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It turned out that tests are failing because I managed to find a bug in mysql/mariadb while trying to find a solution for the original issue: https://jira.mariadb.org/browse/MDEV-21750 As it's a bug, I'm not sure an input validation would help (good duct tape, though). |
|
As an alternative fix for the original issue: prefix matching (and many other features of full-text search) can be displayed on the UI as tooltip or help so the user would include it in his/her search when prefix match is needed. |
|
Hey @rutkai, thank you for taking the time to look at this issue and dump your findings here, it would prove useful the moment much needed improvements are made into search :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #722.
It is not a 100% solution as I just added prefix matching, for pre- and postfix matching
LIKEkeyword would be needed, but that's a volume slower thanMATCH.