Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load tags dynamically using the API instead of on page first load #386

Open
thelazyoxymoron opened this issue Feb 25, 2022 · 10 comments
Open
Labels
type:bug Something isn't working

Comments

@thelazyoxymoron
Copy link

I'm not able to select any tags from the matched list. Using the Arm64 docker image built using the latest codebase.

@fmartingr
Copy link
Member

Where do you have this problem? In the search, in the article list, in the tag list, in the "add bookmark" dialog?

@fmartingr fmartingr added the tag:more-info More information needed label Feb 26, 2022
@thelazyoxymoron
Copy link
Author

I'm facing this in the add new bookmark screen, as well as when I try to edit an existing bookmark. DB is Postgresql.

@fmartingr
Copy link
Member

Just to confirm, the problem is that you don't see the tags input like this:

2022-03-01_12-32-36

Which browser are you suing?

@fmartingr fmartingr added type:bug Something isn't working database:postgres labels Mar 1, 2022
@thelazyoxymoron
Copy link
Author

Just to confirm, the problem is that you don't see the tags input like this:

I see the tags input getting suggested, but not able to select from the suggested list.

Which browser are you suing?

Firefox v97

@fmartingr
Copy link
Member

fmartingr commented Mar 5, 2022

I've just tried this on Firefox 97.0.2 @ macos 12.1 and it's working:

Screen.Recording.2022-03-06.at.00.09.05.mov

I put a few letters and press enter on the suggestion.

Do you see any errors on the firefox console? Tools > Browser Tools > Developer Tools on the Console tab.

@mrex
Copy link

mrex commented Sep 30, 2022

After finding this bug report, I guess I finally understand how tag suggestions are supposed to work. It looks like Shiori's suggestion shows only one of the possible tags, and only when the text entered does not match the suggestion anymore, another possible tag is shown.

That's not intuitive at all. Usually, when you enter a tag the suggestions show all the tags matching the substring typed so far, with a way to select one of the (possibly multiple) suggested tags, either by navigating with the keyboard or by clicking on it.

@fmartingr fmartingr added type:enhancement New feature or request component:frontend The bug is in front-end and removed type:bug Something isn't working tag:more-info More information needed database:postgres labels Oct 3, 2022
@fmartingr
Copy link
Member

Moving this from bug to enhancement, and while agree that the current selector is not optimal I can't consider this a "bug" since it's working as expected. At least until we improve it :)

@thelazyoxymoron if you are experiencing an actual bug please report back so we can take a look at it (and proper triage a new issue for the feature request).

@thelazyoxymoron
Copy link
Author

Apologies for not providing enough information earlier. I did some more testing and looks like this is only happening with Postgres DB backend and only when I try to add a tag in the following window:

image

I did not observe this when trying to edit an existing bookmark and add tags. The auto-suggest + enter was working there. Only observing when adding tags in the "add new bookmar" screen.

This is related to #215.

@fmartingr
Copy link
Member

I've been testing this locally, and after #484 fix for PSQL it now works but there's a caveheat: the frontend loads tags on page load, so if you add a new bookmark with a new tag and then add another bookmark that new tag wont autocomplete unless the page is reloaded.

@fmartingr fmartingr added type:bug Something isn't working and removed type:enhancement New feature or request component:frontend The bug is in front-end labels Oct 4, 2022
@v-marinkov
Copy link

I also confirm I can't click on the suggested tags (Docker, sqlite3, Firefox, Windows). It would be great to have the tags suggestion in the browser extension too (go-shiori/shiori-web-ext#64)

@fmartingr fmartingr changed the title Not able to select already existing tag Load tags dynamically using the API instead of on page first load May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

4 participants