Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] mark bookmarks read #247

Closed
microcreators opened this issue May 5, 2020 · 8 comments
Closed

[request] mark bookmarks read #247

microcreators opened this issue May 5, 2020 · 8 comments
Labels
component:backend component:frontend The bug is in front-end type:enhancement New feature or request

Comments

@microcreators
Copy link

... and move them out of sight. archive them, hide them, etc. but keep them available and searchable in case I need to come back to them one day. Just don't show them in a default view.

@michaelx
Copy link

michaelx commented Jun 1, 2020

This would be a really helpful feature, especially when shiori is used as a read-it-later client.

@thejdev
Copy link

thejdev commented Jun 5, 2020

I agree that this would be a good feature.

As an interim workaround, I use this url as my default start page:
https://shiori-server/?search=-tag%3A*#home

The link above lists bookmarks with no tag (i.e. unread). Once I have read an article, I give it a tag (e.g. Read), and it disappears from the list.

@8bitgentleman
Copy link

8bitgentleman commented Jun 5, 2020

@thejdev I like that idea a lot. To remix it if you set this URL is your home it filters out the tag #read and shows all others. This works really well for me because I use tagging for many other things

http:https://YourShioriServer/?search=-tag%3Aread#home

I wish shiori did filtering in real time though. That's the downside I see, you need to refresh the page for any new tagged articles to be filtered out.

@deanishe deanishe added the type:enhancement New feature or request label Aug 6, 2020
@deanishe
Copy link
Contributor

deanishe commented Aug 6, 2020

Hi guys. I'm your new Shiori maintainer.

This feature is a high priority for me. Specifically, I want to add support for read, starred and—possibly—archived status.

Right now, I'm thinking of something along the lines that @thejdev suggests: basically just using tags, but treating certain tags (e.g. unread, starred) specially in the UI.

There's some "infrastructural" stuff that needs doing first, though.

@microcreators
Copy link
Author

First of all, thanks for reviving the project, appreciate it. If I can suggest something here, start easy with the change. Maybe just one special tag for starters like read? I think I'd be simpler to add this vs. having everything else tagged as unread.

@deanishe
Copy link
Contributor

deanishe commented Aug 8, 2020

I think I'd be simpler to add this vs. having everything else tagged as unread.

What makes you say it would be simpler?

I think the main difference is whether you think a "read later" list should be opt-in (add unread) or opt-out (add read).

I'm more inclined to the former (tag as unread to add to "read later" list) because I don't want an update to automatically shunt everybody's entire list of existing bookmarks (and any new ones they add/import) into their new "read later" list (because they aren't tagged as read).

Existing users have probably read most of the articles they're interested in by this point, and they may not even want to use the feature. That's a better fit with the opt-in unread model.

@microcreators
Copy link
Author

Honestly - it doesn't matter. 99% of my bookmarks are read and stored "just in case" (it's a knowledge base for me). I think it's a matter of default tagging. If everything is unread by default, there will be (a lot of) manual work to hide what's no longer fresh.

@deanishe
Copy link
Contributor

deanishe commented Aug 8, 2020

If everything is unread by default, there will be (a lot of) manual work to hide what's no longer fresh.

Exactly. That's why I prefer "tag unread to add to read-later list".

Of course, it's simple enough to automatically add any tag to items on database migration or when importing/adding.

So, it's really a question of opt-in vs opt-out, and currently I'm quite strongly inclined towards opt-in.

@go-shiori go-shiori locked and limited conversation to collaborators Feb 6, 2022
@fmartingr fmartingr converted this issue into discussion #343 Feb 6, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
component:backend component:frontend The bug is in front-end type:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants