Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Annotating articles #107

Closed
ibnishak opened this issue Aug 1, 2018 · 6 comments
Closed

Feature request: Annotating articles #107

ibnishak opened this issue Aug 1, 2018 · 6 comments

Comments

@ibnishak
Copy link

ibnishak commented Aug 1, 2018

Please add the ability to add annotations to the articles.

@RadhiFadlillah
Copy link
Collaborator

RadhiFadlillah commented Aug 27, 2019

I'm sorry, but I don't think I could do this.

First, I don't think annotation is the task for bookmark manager like Shiori. Second (and the main reason), it's quite hard to do and I think it will add too much complexity to code base.

Unfortunately, Shiori's code is not really nice right now, mostly because of new support for archiving web page. There are several parts of code that IMHO too convoluted and repeated multiple times, which make it a bit hard to read.

@8bitgentleman
Copy link

8bitgentleman commented Mar 27, 2020

@RadhiFadlillah I know you're not keen on adding annotation to shiori but have you considered integrating an open source annotation platform into shiori instead? I'm specifically thinking of hypothes.is which can be embedded into applications, websites, and interfaces and works with either a publicly hosted central server or your own self-hosted solution. All their code is on github and their documentation is pretty good.

@Mohan-cloud
Copy link

I also think this will be a useful feature. Can this be revisited?

@KhaaL
Copy link

KhaaL commented Jun 28, 2024

For those who want annotation built in, omnivore has this capability built-in, but I think its too big for if you have a small amount of users.

I recently discovered Shiori and find it really awesome - even though I sorely miss highlighting text, I respect @RadhiFadlillah decision to keep the codebase small and lean.

@fmartingr
Copy link
Member

Right now what I do is get the epub from the bookmark and annotate it in my tablet. Is not really convenient but easy to capture thoughts. Quotes go on to obsidian.

Just curious, since this issue predates me, how would this look on the UI? What are the expectations?

@Monirzadeh
Copy link
Collaborator

Monirzadeh commented Jun 28, 2024

If i remmember correctly With koreader we can send back annotated to server.
The hard part is how we should store annotates in database for each article? while user can update readable version and it possible that specific part change in article after update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants