Support proxy or pac files.

[Monirzadeh]

it is good if shiori can get PAC file to use proxy for external connection.
unfortunately some person in world don't have free access to internet and they are under heavy censorship for access to the internet or need specific rule for accesses specific site.
support proxy can help them a lot (more that you think)

any body have better idea instead of impediment that in application level that work without problem?

[fmartingr]

Have you tried using the HTTP_PROXY and HTTPS_PROXY variables? Go should respect those when making requests.

[Monirzadeh]

don't worry. i work on that and test your suggestion for find a good solution.
unfortunately i should know about this stuff.

[mrchang2017]

Hello. It didn't work on docker container while HTTP_PROXY, HTTPS_PROXY existing. Maybe we should provide some variable to the HTTP client function.

[Monirzadeh]

i test that on local machine not docker yet (proxy is on docker it self that listen on specific port) and work fine. the way i done unfortunately is not exactly PAC file but similar.
what is the problem exactly?
why you need setHTTP_PROXY HTTPS_PROXY for other propose?
shiori work correctly?
your proxy exclude local range IP?
what type of proxy you use for HTTP_PROXY, HTTPS_PROXY do you set socks?
can you provide some link that you have problem with it?
do you get something like this in log?
error downloading boorkmark: error downloading url: Get "your url": net/http: TLS handshake timeout

i am not close this because not test that myself on docker yet and not deep enough.

[mrchang2017]

In my Shiori Container, I set HTTP_PROXY, HTTPS_PROXY, http_proxy, https_proxy to "http:https://hostname.local:7890", which is a http proxy. But I saw no fetching action from Shiori in Proxy log file.

Also in Shiori Log file:

2023/09/14 15:07:10 error downloading boorkmark: error downloading url: Get "{URL}": dial tcp 173.252.*.*:443: i/o timeout

[mrchang2017]

Hello, Buddy; I found that in the Shiori Container, NO_PROXY, no_proxy environment variables were both set to "*". I deleted it and the proxy worked.