Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation for Other tags? Eg: required_without? #697

Closed
frederikhors opened this issue Dec 4, 2020 · 2 comments · Fixed by #884
Closed

Translation for Other tags? Eg: required_without? #697

frederikhors opened this issue Dec 4, 2020 · 2 comments · Fixed by #884
Labels
help wanted

Comments

@frederikhors
Copy link
Contributor

Package version: v10

Issue, Question or Enhancement:

Am I wrong or there is no translation for the requireds other than for the default one?

Example: is there a translation for required_without?
@deankarn
Copy link
Contributor

It is possible this has been missed.

If so happy to accept PR's to correct.

@renato0307 renato0307 mentioned this issue Jan 14, 2022
Merged
1 task
@renato0307
Copy link
Contributor

renato0307 commented Jan 14, 2022 •
edited
Loading

@deankarn I'm new to the repo but I can pick this one.

I've created a draft PR with the en translation for required_if.

Is this the right approach?

Cheers,
Renato

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #697 - add missing "en" translations for "required" tags renato0307/validator
3 participants
@renato0307 @deankarn @frederikhors