add 'npm' and 'npm-update' make targets and lockfile #7246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That’s a little too long to type though especially if my terminal doesn’t have auto completion for make..
|
|
Indeed, I had a similar thought. Still think it should be two targets, thought. |
|
Renamed to |
- `make npm` installs and updates node_modules, triggered automatically on `make css` and `make js` as it completes reasonably fast and ensures consistent modules. - `make npm-update` updates all dependencies to their latest version, regenerates `node_modules` from scratch and updates `package-lock.json`. It uses npm modules `updates` written by yours truly to find the latest version of each dependency.
Codecov Report
@@ Coverage Diff @@
## master #7246 +/- ##
==========================================
- Coverage 40.99% 40.97% -0.02%
==========================================
Files 462 462
Lines 62585 62585
==========================================
- Hits 25654 25644 -10
- Misses 33571 33580 +9
- Partials 3360 3361 +1
Continue to review full report at Codecov.
|
adelowo
approved these changes
Jun 18, 2019
mrsdizzie
suggested changes
Jun 18, 2019
sapk
suggested changes
Jun 18, 2019
|
Ran |
sapk
approved these changes
Jun 18, 2019
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
* add 'npm' and 'npm-update' make targets and lockfile - `make npm` installs and updates node_modules, triggered automatically on `make css` and `make js` as it completes reasonably fast and ensures consistent modules. - `make npm-update` updates all dependencies to their latest version, regenerates `node_modules` from scratch and updates `package-lock.json`. It uses npm modules `updates` written by yours truly to find the latest version of each dependency. * add suggested make dependencies * remove package-lock.json during npm-update * regenerate package-lock.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make npminstalls and updatesnode_modules, triggered automatically onmake cssandmake jsas it completes reasonably fast and ensures consistent modules.make npm-updateupdates all dependencies to their latest version, regeneratesnode_modulesfrom scratch and updatespackage-lock.json. It uses npm modulesupdateswritten by yours truly to find the latest version of each dependency.