Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid arbitrary format strings upon calling fail() function #7112

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Avoid arbitrary format strings upon calling fail() function #7112

merged 1 commit into from
Jun 3, 2019

Conversation

strk
Copy link
Member

@strk strk commented Jun 3, 2019

Might fix #7111, although I didn't verify this

@strk strk mentioned this pull request Jun 3, 2019
Closed
zeripath
zeripath approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about this @strk I must have missed this during fixing conflicts in #6993

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 3, 2019
@zeripath zeripath added this to the 1.9.0 milestone Jun 3, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 3, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@9002c51). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7112   +/-   ##
=========================================
  Coverage          ?   41.53%           
=========================================
  Files             ?      446           
  Lines             ?    60825           
  Branches          ?        0           
=========================================
  Hits              ?    25266           
  Misses            ?    32276           
  Partials          ?     3283

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9002c51...f71ad09. Read the comment docs.

@zeripath zeripath merged commit 45f588e into go-gitea:master Jun 3, 2019
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@strk @jeffliu27
Avoid arbitrary format strings upon calling fail() function (go-gitea…
73f570d 
…#7112)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

invalid memory address or nil pointer dereference upon attempting to write to an unauthorized repo via ssh
5 participants
@strk @codecov-io @lafriks @zeripath @GiteaBot