Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dropdown icon padding #6651

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Fix dropdown icon padding #6651

merged 1 commit into from
Apr 16, 2019

Conversation

zeripath
Copy link
Contributor

The dropdown icon have too much bottom padding. This PR fixes this.

From:
dropdown-too-padded

To:
dropdown-fixed

Signed-off-by: Andrew Thornton [email protected]

@zeripath
Fix dropdown icon padding
d733ec9 
Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added backport/v1.8 topic/ui Change the appearance of the Gitea UI labels Apr 16, 2019
@zeripath zeripath added this to the 1.9.0 milestone Apr 16, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 16, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 16, 2019
@codecov-io
Copy link

Codecov Report

Merging #6651 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6651      +/-   ##
==========================================
- Coverage   40.55%   40.54%   -0.01%     
==========================================
  Files         406      406              
  Lines       54501    54501              
==========================================
- Hits        22101    22100       -1     
- Misses      29362    29365       +3     
+ Partials     3038     3036       -2
Impacted Files Coverage Δ
models/unit.go 0% <0%> (-14.29%) ⬇️
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️
modules/log/log.go 71.42% <0%> (+2.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bce189...d733ec9. Read the comment docs.

@techknowlogick techknowlogick merged commit 8d01b98 into go-gitea:master Apr 16, 2019
@zeripath zeripath deleted the fix-dropdown-icon-padding branch April 16, 2019 16:32
zeripath added a commit to zeripath/gitea that referenced this pull request Apr 16, 2019
@zeripath
Fix dropdown icon padding (go-gitea#6651)
23c0736 
Signed-off-by: Andrew Thornton <[email protected]>
techknowlogick pushed a commit that referenced this pull request Apr 16, 2019
@zeripath @techknowlogick
Fix dropdown icon padding (#6651) (#6654)
5876e37 
Signed-off-by: Andrew Thornton <[email protected]>
@lunny
Copy link
Member

lunny commented Apr 17, 2019

Please send back port to v1.8

@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Apr 17, 2019
@techknowlogick
Copy link
Member

@lunny done.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@adelowo adelowo adelowo approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zeripath @codecov-io @lunny @techknowlogick @adelowo @GiteaBot