add org level milestones

[iminfinity]

#20203

org-mile.mp4

PR sponsored by Obmondo.com

[silverwind]

Suggested change

[silverwind]

Suggested change

[silverwind]

Suggested change

	<a class="ui primary basic button" href="{{.OrgLink}}/milestones">
	<a class="ui basic button" href="{{.OrgLink}}/milestones">

Generally there should only be one primary button per button group

[silverwind]

Suggested change

	<a class="ui primary basic button link-action" href data-url="{{$.Link}}/open">{{ctx.Locale.Tr "repo.milestones.open"}}
	</a>
	{{else}}
	<a class="ui red basic button link-action" href data-url="{{$.Link}}/close">{{ctx.Locale.Tr "repo.milestones.close"}}
	<a class="ui primary button link-action" href data-url="{{$.Link}}/open">{{ctx.Locale.Tr "repo.milestones.open"}}
	</a>
	{{else}}
	<a class="ui red button link-action" href data-url="{{$.Link}}/close">{{ctx.Locale.Tr "repo.milestones.close"}}

Likely this looks better.

[silverwind]

These gt- classes no longer exist so this is surely broken, please migrate to Tailwind.css's tw- classes.

[iminfinity]

this pr was created before the tailwind switch, i updated our gitea but forgot this pr, will fix this and all other lint issue

[silverwind]

Suggested change

[silverwind]

Suggested change

	{{template "repo/issue/filters" .}}
	{{template "repo/issue/filters" .}}

[silverwind]

This PR is coming from an org, so maintainers have no push permission to the source branch. Can this be allowed somehow? Would make things easier.

[iminfinity]

This PR is coming from an org, so maintainers have no push permission to the source branch. Can this be allowed somehow? Would make things easier.

i have no idea, let me ask someone

[KlavsKlavsen]

This PR is coming from an org, so maintainers have no push permission to the source branch. Can this be allowed somehow? Would make things easier.

So you want to push to "source branch" in source repo (the fork) ? that sounds very odd.. that would not work even if I forked it to my personal repo ? that sounds weird.. :)

If you know of any org settings for the org - I can change them though as I am org owner though.

@iminfinity will fix merge conflict and other things, so its good to merge right?

[KlavsKlavsen]

in this case - @iminfinity will have to update our fork of latest main and then re-apply/adjust his commits to work (and test ofcourse) - and then push the updated change so it matches

[silverwind]

Maybe it'd be easier if you re-raise the PR from a user account so that we can push fixes onto this branch. I don't know why GitHub has this silly restriction to not allow collaboration on org branches.

[wxiaoguang]

I could try to explain more: we encourage contributors to enable "Allow maintainers to edit" for their PRs, then maintainers could help to improve the code together and update&merge.

---

However, GitHub has a restriction: if a PR is from an org, then no maintainer could edit that PR. That's why the PRs from an org are difficult to review&improve.

If a PR is from a user's account and allows maintainers to edit, then some maintainers who have interests and experiences could work together to try to complete it.

[wxiaoguang]

And one more thing, there are still many problems, for example: the db migration should use XORM sync, many CSS styles are no long available ("gt-mr-2" / "mr-2"), coding-style (use template {{}} instead of print), duplicate code (some code blocks are copied&pasted?), strange key/variable (orgPath), etc. And it's better to have some tests to cover the new logic.

Haven't really taken a look carefully, but I guess it's far from mature.