Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include encoding in signature payload #30174

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Mar 29, 2024

Fixes #30119

Include the encoding in the signature payload.

before
grafik

after
grafik

@KN4CK3R KN4CK3R added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 backport/v1.22 This PR should be backported to Gitea 1.22 labels Mar 29, 2024
@KN4CK3R KN4CK3R added this to the 1.22.0 milestone Mar 29, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 29, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 29, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 29, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 29, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 29, 2024
@KN4CK3R KN4CK3R enabled auto-merge (squash) March 29, 2024 21:28
@KN4CK3R KN4CK3R merged commit b6a3cd4 into go-gitea:main Mar 29, 2024
26 checks passed
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 30, 2024
* giteaofficial/main:
  Include encoding in signature payload (go-gitea#30174)
  Add `stylelint-value-no-unknown-custom-properties` and convert stylelint config to js (go-gitea#30117)
  Remove jQuery class from the commit button (go-gitea#30178)
  Remove jQuery class from the diff view (go-gitea#30176)
  Remove jQuery class from the notification count (go-gitea#30172)
  Remove jQuery class from the code range selection (go-gitea#30173)
  Fix:the rounded corners of the folded file are not displayed correctly (go-gitea#29953)
  Add setting to disable user features when user login type is not plain (go-gitea#29615)

# Conflicts:
#	models/user/user.go
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.22. @KN4CK3R, please send one manually. 🍵

go run ./contrib/backport 30174
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Mar 30, 2024
@lunny lunny added the backport/done All backports for this PR have been created label Mar 30, 2024
@KN4CK3R KN4CK3R deleted the fix-commit-signature branch March 31, 2024 08:03
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commits which include encoding header fail to verify when otherwise valid
5 participants