Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid link of the commit status when ref is tag (#29752) #29908

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Fix invalid link of the commit status when ref is tag (#29752) #29908

merged 3 commits into from
Mar 20, 2024

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Mar 19, 2024

Backport #29752

@GiteaBot GiteaBot added this to the 1.21.9 milestone Mar 19, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 19, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 19, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 19, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 19, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 19, 2024
@silverwind silverwind self-requested a review March 19, 2024 10:34
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Mar 19, 2024
@silverwind
Copy link
Member

Test failure related.

@yp05327
Copy link
Contributor Author

yp05327 commented Mar 19, 2024 •
edited
Loading

I know the reason now, although we called UpdateRepositoryUnits, but it will only update DB, but not update repo.Units.

@yp05327
Copy link
Contributor Author

yp05327 commented Mar 19, 2024

And another different thing is that after calling notify_service.CreateRepository(ctx, doer, owner, repo)
repo.Units will be loaded, and in 1.21 action unit is not listed in it, but in the latest version, it will.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 20, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 20, 2024
@lunny lunny enabled auto-merge (squash) March 20, 2024 04:14
@lunny lunny merged commit aae96cc into go-gitea:release/v1.21 Mar 20, 2024
27 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 20, 2024
@yp05327 yp05327 deleted the backport-29752 branch March 21, 2024 00:47
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wolfogre wolfogre wolfogre approved these changes

@silverwind silverwind Awaiting requested review from silverwind

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.21.9
Development

Successfully merging this pull request may close these issues.
5 participants
@yp05327 @silverwind @lunny @wolfogre @GiteaBot