Fix template error when comment review doesn't exist (#29888)

models/fixtures/comment.yml

@@ -75,3 +75,11 @@
  content: "comment in private pository"
  created_unix: 946684811
  updated_unix: 946684811
+
+-
+ id: 9
+ type: 22 # review
+ poster_id: 2
+ issue_id: 2 # in repo_id 1
+ review_id: 20
+ created_unix: 946684810

models/fixtures/review.yml

@@ -170,3 +170,12 @@
  content: "review request for user15"
  updated_unix: 946684835
  created_unix: 946684835
+
+-
+ id: 20
+ type: 22
+ reviewer_id: 1
+ issue_id: 2
+ content: "Review Comment"
+ updated_unix: 946684810
+ created_unix: 946684810

routers/web/repo/pull_review_test.go

@@ -4,6 +4,7 @@
 package repo
 
 import (
+ "net/http"
  "net/http/httptest"
  "testing"
 
@@ -73,4 +74,20 @@ func TestRenderConversation(t *testing.T) {
  renderConversation(ctx, preparedComment, "timeline")
  assert.Contains(t, resp.Body.String(), `<div id="code-comments-`)
  })
+ run("diff non-existing review", func(t *testing.T, ctx *context.Context, resp *httptest.ResponseRecorder) {
+ err := db.TruncateBeans(db.DefaultContext, &issues_model.Review{})
+ assert.NoError(t, err)
+ ctx.Data["ShowOutdatedComments"] = true
+ renderConversation(ctx, preparedComment, "diff")
+ assert.Equal(t, http.StatusOK, resp.Code)
+ assert.NotContains(t, resp.Body.String(), `status-page-500`)
+ })
+ run("timeline non-existing review", func(t *testing.T, ctx *context.Context, resp *httptest.ResponseRecorder) {
+ err := db.TruncateBeans(db.DefaultContext, &issues_model.Review{})
+ assert.NoError(t, err)
+ ctx.Data["ShowOutdatedComments"] = true
+ renderConversation(ctx, preparedComment, "timeline")
+ assert.Equal(t, http.StatusOK, resp.Code)
+ assert.NotContains(t, resp.Body.String(), `status-page-500`)
+ })
 }

templates/repo/diff/comments.tmpl

@@ -37,7 +37,7 @@
  {{ctx.Locale.Tr "repo.issues.review.outdated"}}
  </a>
  {{end}}
- {{if and .Review}}
+ {{if .Review}}
  {{if eq .Review.Type 0}}
  <div class="ui label basic small yellow pending-label" data-tooltip-content="{{ctx.Locale.Tr "repo.issues.review.pending.tooltip" (ctx.Locale.Tr "repo.diff.review") (ctx.Locale.Tr "repo.diff.review.approve") (ctx.Locale.Tr "repo.diff.review.comment") (ctx.Locale.Tr "repo.diff.review.reject")}}">
  {{ctx.Locale.Tr "repo.issues.review.pending"}}

templates/repo/diff/conversation.tmpl

@@ -1,9 +1,12 @@
-{{$resolved := (index .comments 0).IsResolved}}
-{{$invalid := (index .comments 0).Invalidated}}
-{{$resolveDoer := (index .comments 0).ResolveDoer}}
-{{$isNotPending := (not (eq (index .comments 0).Review.Type 0))}}
-{{$referenceUrl := printf "%s#%s" $.Issue.Link (index .comments 0).HashTag}}
-<div class="conversation-holder" data-path="{{(index .comments 0).TreePath}}" data-side="{{if lt (index .comments 0).Line 0}}left{{else}}right{{end}}" data-idx="{{(index .comments 0).UnsignedLine}}">
+{{if len .comments}}
+ {{$comment := index .comments 0}}
+ {{$resolved := $comment.IsResolved}}
+ {{$invalid := $comment.Invalidated}}
+ {{$resolveDoer := $comment.ResolveDoer}}
+ {{$hasReview := and $comment.Review}}
+ {{$isReviewPending := and $hasReview (eq $comment.Review.Type 0)}}
+ {{$referenceUrl := printf "%s#%s" $.Issue.Link $comment.HashTag}}
+ <div class="conversation-holder" data-path="{{$comment.TreePath}}" data-side="{{if lt $comment.Line 0}}left{{else}}right{{end}}" data-idx="{{$comment.UnsignedLine}}">
  {{if $resolved}}
  <div class="ui attached header resolved-placeholder gt-df gt-ac gt-sb">
  <div class="ui grey text gt-df gt-ac gt-fw gt-gap-2">
@@ -20,18 +23,18 @@
  {{end}}
  </div>
  <div class="gt-df gt-ac gt-gap-3">
- <button id="show-outdated-{{(index .comments 0).ID}}" data-comment="{{(index .comments 0).ID}}" class="ui tiny labeled button show-outdated gt-df gt-ac">
+  <button id="show-outdated-{{$comment.ID}}" data-comment="{{$comment.ID}}" class="ui tiny labeled button show-outdated gt-df gt-ac">
  {{svg "octicon-unfold" 16 "gt-mr-3"}}
  {{ctx.Locale.Tr "repo.issues.review.show_resolved"}}
  </button>
- <button id="hide-outdated-{{(index .comments 0).ID}}" data-comment="{{(index .comments 0).ID}}" class="ui tiny labeled button hide-outdated gt-df gt-ac gt-hidden">
+  <button id="hide-outdated-{{$comment.ID}}" data-comment="{{$comment.ID}}" class="ui tiny labeled button hide-outdated gt-df gt-ac gt-hidden">
  {{svg "octicon-fold" 16 "gt-mr-3"}}
  {{ctx.Locale.Tr "repo.issues.review.hide_resolved"}}
  </button>
  </div>
  </div>
  {{end}}
- <div id="code-comments-{{(index .comments 0).ID}}" class="field comment-code-cloud {{if $resolved}}gt-hidden{{end}}">
+  <div id="code-comments-{{$comment.ID}}" class="field comment-code-cloud {{if $resolved}}gt-hidden{{end}}">
  <div class="comment-list">
  <ui class="ui comments">
  {{template "repo/diff/comments" dict "root" $ "comments" .comments}}
@@ -46,8 +49,8 @@
  {{svg "octicon-arrow-down" 12 "icon"}} {{ctx.Locale.Tr "repo.issues.next"}}
  </button>
  </div>
- {{if and $.CanMarkConversation $isNotPending}}
- <button class="ui icon tiny basic button resolve-conversation" data-origin="diff" data-action="{{if not $resolved}}Resolve{{else}}UnResolve{{end}}" data-comment-id="{{(index .comments 0).ID}}" data-update-url="{{$.RepoLink}}/issues/resolve_conversation">
+  {{if and $.CanMarkConversation $hasReview (not $isReviewPending)}}
+  <button class="ui icon tiny basic button resolve-conversation" data-origin="diff" data-action="{{if not $resolved}}Resolve{{else}}UnResolve{{end}}" data-comment-id="{{$comment.ID}}" data-update-url="{{$.RepoLink}}/issues/resolve_conversation">
  {{if $resolved}}
  {{ctx.Locale.Tr "repo.issues.review.un_resolve_conversation"}}
  {{else}}
@@ -61,6 +64,9 @@
  </button>
  {{end}}
  </div>
- {{template "repo/diff/comment_form_datahandler" dict "hidden" true "reply" (index .comments 0).ReviewID "root" $ "comment" (index .comments 0)}}
+  {{template "repo/diff/comment_form_datahandler" dict "hidden" true "reply" $comment.ReviewID "root" $ "comment" $comment}}
  </div>
  </div>
+{{else}}
+ {{template "repo/diff/conversation_outdated"}}
+{{end}}

templates/repo/issue/view_content/comments.tmpl

@@ -365,16 +365,20 @@
  {{else if eq .Type 22}}
  <div class="timeline-item-group">
  <div class="timeline-item event">
+ {{$reviewType := -1}}
+ {{if .Review}}{{$reviewType = .Review.Type}}{{end}}
  {{if .OriginalAuthor}}
  {{else}}
  {{/* Some timeline avatars need a offset to correctly align with their speech
  bubble. The condition depends on review type and for positive reviews whether
  there is a comment element or not */}}
- <a class="timeline-avatar{{if or (and (eq .Review.Type 1) (or .Content .Attachments)) (and (eq .Review.Type 2) (or .Content .Attachments)) (eq .Review.Type 3)}} timeline-avatar-offset{{end}}"{{if gt .Poster.ID 0}} href="{{.Poster.HomeLink}}"{{end}}>
+ <a class="timeline-avatar{{if or (and (eq $reviewType 1) (or .Content .Attachments)) (and (eq $reviewType 2) (or .Content .Attachments)) (eq $reviewType 3)}} timeline-avatar-offset{{end}}"{{if gt .Poster.ID 0}} href="{{.Poster.HomeLink}}"{{end}}>
  {{ctx.AvatarUtils.Avatar .Poster 40}}
  </a>
  {{end}}
- <span class="badge{{if eq .Review.Type 1}} gt-bg-green gt-text-white{{else if eq .Review.Type 3}} gt-bg-red gt-text-white{{end}}">{{svg (printf "octicon-%s" .Review.Type.Icon)}}</span>
+ <span class="badge{{if eq $reviewType 1}} gt-bg-green gt-text-white{{else if eq $reviewType 3}} gt-bg-red gt-text-white{{end}}">
+ {{if .Review}}{{svg (printf "octicon-%s" .Review.Type.Icon)}}{{end}}
+ </span>
  <span class="text grey muted-links">
  {{if .OriginalAuthor}}
  <span class="text black">
@@ -387,16 +391,16 @@
  {{template "shared/user/authorlink" .Poster}}
  {{end}}
 
- {{if eq .Review.Type 1}}
+ {{if eq $reviewType 1}}
  {{ctx.Locale.Tr "repo.issues.review.approve" $createdStr | Safe}}
- {{else if eq .Review.Type 2}}
+ {{else if eq $reviewType 2}}
  {{ctx.Locale.Tr "repo.issues.review.comment" $createdStr | Safe}}
- {{else if eq .Review.Type 3}}
+ {{else if eq $reviewType 3}}
  {{ctx.Locale.Tr "repo.issues.review.reject" $createdStr | Safe}}
  {{else}}
  {{ctx.Locale.Tr "repo.issues.review.comment" $createdStr | Safe}}
  {{end}}
- {{if .Review.Dismissed}}
+ {{if and .Review .Review.Dismissed}}
  <div class="ui small label">{{ctx.Locale.Tr "repo.issues.review.dismissed_label"}}</div>
  {{end}}
  </span>
@@ -456,7 +460,7 @@
  </div>
  {{end}}
 
- {{if .Review.CodeComments}}
+ {{if and .Review .Review.CodeComments}}
  <div class="timeline-item event">
  {{range $filename, $lines := .Review.CodeComments}}
  {{range $line, $comms := $lines}}
@@ -610,11 +614,13 @@
  <span class="text grey muted-links">
  {{template "shared/user/authorlink" .Poster}}
  {{$reviewerName := ""}}
+ {{if .Review}}
  {{if eq .Review.OriginalAuthor ""}}
  {{$reviewerName = .Review.Reviewer.Name}}
  {{else}}
  {{$reviewerName = .Review.OriginalAuthor}}
  {{end}}
+ {{end}}
  <span class="dismissed-message">{{ctx.Locale.Tr "repo.issues.review.dismissed" ($reviewerName | Escape) $createdStr | Safe}}</span>
  </span>
  </div>

templates/repo/issue/view_content/conversation.tmpl

@@ -1,11 +1,14 @@
-{{$invalid := (index .comments 0).Invalidated}}
-{{$resolved := (index .comments 0).IsResolved}}
-{{$resolveDoer := (index .comments 0).ResolveDoer}}
-{{$isNotPending := (not (eq (index .comments 0).Review.Type 0))}}
+{{if len .comments}}
+ {{$comment := index .comments 0}}
+ {{$invalid := $comment.Invalidated}}
+ {{$resolved := $comment.IsResolved}}
+ {{$resolveDoer := $comment.ResolveDoer}}
+ {{$hasReview := and $comment.Review}}
+ {{$isReviewPending := and $hasReview (eq $comment.Review.Type 0)}}
  <div class="ui segments conversation-holder">
  <div class="ui segment collapsible-comment-box gt-py-3 gt-df gt-ac gt-sb">
  <div class="gt-df gt-ac">
- <a href="{{(index .comments 0).CodeCommentLink ctx}}" class="file-comment gt-ml-3 gt-word-break">{{(index .comments 0).TreePath}}</a>
+  <a href="{{$comment.CodeCommentLink ctx}}" class="file-comment gt-ml-3 gt-word-break">{{$comment.TreePath}}</a>
  {{if $invalid}}
  <span class="ui label basic small gt-ml-3" data-tooltip-content="{{ctx.Locale.Tr "repo.issues.review.outdated_description"}}">
  {{ctx.Locale.Tr "repo.issues.review.outdated"}}
@@ -14,15 +17,15 @@
  </div>
  <div>
  {{if or $invalid $resolved}}
- <button id="show-outdated-{{(index .comments 0).ID}}" data-comment="{{(index .comments 0).ID}}" class="{{if not $resolved}}gt-hidden {{end}}ui compact labeled button show-outdated gt-df gt-ac">
+  <button id="show-outdated-{{$comment.ID}}" data-comment="{{$comment.ID}}" class="{{if not $resolved}}gt-hidden {{end}}ui compact labeled button show-outdated gt-df gt-ac">
  {{svg "octicon-unfold" 16 "gt-mr-3"}}
  {{if $resolved}}
  {{ctx.Locale.Tr "repo.issues.review.show_resolved"}}
  {{else}}
  {{ctx.Locale.Tr "repo.issues.review.show_outdated"}}
  {{end}}
  </button>
- <button id="hide-outdated-{{(index .comments 0).ID}}" data-comment="{{(index .comments 0).ID}}" class="{{if $resolved}}gt-hidden {{end}}ui compact labeled button hide-outdated gt-df gt-ac">
+  <button id="hide-outdated-{{$comment.ID}}" data-comment="{{$comment.ID}}" class="{{if $resolved}}gt-hidden {{end}}ui compact labeled button hide-outdated gt-df gt-ac">
  {{svg "octicon-fold" 16 "gt-mr-3"}}
  {{if $resolved}}
  {{ctx.Locale.Tr "repo.issues.review.hide_resolved"}}
@@ -33,10 +36,10 @@
  {{end}}
  </div>
  </div>
- {{$diff := (CommentMustAsDiff (index .comments 0))}}
+  {{$diff := (CommentMustAsDiff $comment)}}
  {{if $diff}}
  {{$file := (index $diff.Files 0)}}
- <div id="code-preview-{{(index .comments 0).ID}}" class="ui table segment{{if $resolved}} gt-hidden{{end}}">
+  <div id="code-preview-{{$comment.ID}}" class="ui table segment{{if $resolved}} gt-hidden{{end}}">
  <div class="diff-file-box diff-box file-content {{TabSizeClass $.Editorconfig $file.Name}}">
  <div class="file-body file-code code-view code-diff code-diff-unified unicode-escaped">
  <table>
@@ -48,7 +51,7 @@
  </div>
  </div>
  {{end}}
- <div id="code-comments-{{(index .comments 0).ID}}" class="comment-code-cloud ui segment{{if $resolved}} gt-hidden{{end}}">
+  <div id="code-comments-{{$comment.ID}}" class="comment-code-cloud ui segment{{if $resolved}} gt-hidden{{end}}">
  <div class="ui comments gt-mb-0">
  {{range .comments}}
  {{$createdSubStr:= TimeSinceUnix .CreatedUnix ctx.Locale}}
@@ -112,8 +115,8 @@
  {{end}}
  </div>
  <div class="code-comment-buttons-buttons">
- {{if and $.CanMarkConversation $isNotPending}}
- <button class="ui tiny basic button resolve-conversation" data-origin="timeline" data-action="{{if not $resolved}}Resolve{{else}}UnResolve{{end}}" data-comment-id="{{(index .comments 0).ID}}" data-update-url="{{$.RepoLink}}/issues/resolve_conversation">
+  {{if and $.CanMarkConversation $hasReview (not $isReviewPending)}}
+  <button class="ui tiny basic button resolve-conversation" data-origin="timeline" data-action="{{if not $resolved}}Resolve{{else}}UnResolve{{end}}" data-comment-id="{{$comment.ID}}" data-update-url="{{$.RepoLink}}/issues/resolve_conversation">
  {{if $resolved}}
  {{ctx.Locale.Tr "repo.issues.review.un_resolve_conversation"}}
  {{else}}
@@ -128,6 +131,9 @@
  {{end}}
  </div>
  </div>
- {{template "repo/diff/comment_form_datahandler" dict "hidden" true "reply" (index .comments 0).ReviewID "root" $ "comment" (index .comments 0)}}
+  {{template "repo/diff/comment_form_datahandler" dict "hidden" true "reply" $comment.ReviewID "root" $ "comment" $comment}}
  </div>
  </div>
+{{else}}
+ {{template "repo/diff/conversation_outdated"}}
+{{end}}

tests/integration/pull_review_test.go

@@ -13,6 +13,7 @@ import (
  issues_model "code.gitea.io/gitea/models/issues"
  "code.gitea.io/gitea/models/unittest"
  user_model "code.gitea.io/gitea/models/user"
+ "code.gitea.io/gitea/modules/test"
  repo_service "code.gitea.io/gitea/services/repository"
  files_service "code.gitea.io/gitea/services/repository/files"
  "code.gitea.io/gitea/tests"
@@ -25,10 +26,19 @@ func TestPullView_ReviewerMissed(t *testing.T) {
  session := loginUser(t, "user1")
 
  req := NewRequest(t, "GET", "/pulls")
- session.MakeRequest(t, req, http.StatusOK)
+ resp := session.MakeRequest(t, req, http.StatusOK)
+ assert.True(t, test.IsNormalPageCompleted(resp.Body.String()))
 
  req = NewRequest(t, "GET", "/user2/repo1/pulls/3")
- session.MakeRequest(t, req, http.StatusOK)
+ resp = session.MakeRequest(t, req, http.StatusOK)
+ assert.True(t, test.IsNormalPageCompleted(resp.Body.String()))
+
+ // if some reviews are missing, the page shouldn't fail
+ err := db.TruncateBeans(db.DefaultContext, &issues_model.Review{})
+ assert.NoError(t, err)
+ req = NewRequest(t, "GET", "/user2/repo1/pulls/2")
+ resp = session.MakeRequest(t, req, http.StatusOK)
+ assert.True(t, test.IsNormalPageCompleted(resp.Body.String()))
 }
 
 func TestPullView_CodeOwner(t *testing.T) {