Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set pre-step status to skipped if job is skipped (#29489) #29523

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Set pre-step status to skipped if job is skipped (#29489) #29523

merged 1 commit into from
Mar 1, 2024

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Mar 1, 2024

Backport #29489 by @sillyguodong

close #27496

  1. Set pre-step (Set up job) status to skipped if job is skipped.
  2. Apart from pre-step, the other steps should also be set to skipped. The status of other steps are reported from the runner side. This will be completed by this PR: https://gitea.com/gitea/act_runner/pulls/500

before:
image

after:
image

@sillyguodong @GiteaBot
Set pre-step status to skipped if job is skipped (go-gitea#29489)
84a064a 
close go-gitea#27496
1. Set pre-step (Set up job) status to `skipped` if job is skipped.
2. Apart from pre-step, the other steps should also be set to `skipped`.
The status of other steps are reported from the runner side. This will
be completed by this PR: https://gitea.com/gitea/act_runner/pulls/500

before:

![image](https://github.com/go-gitea/gitea/assets/33891828/4bac2ba9-66de-4679-b7ed-fbae459c0c54)

after:

![image](https://github.com/go-gitea/gitea/assets/33891828/ead4871a-4e0f-4bb1-9fb4-37f4fdb78dfc)
@GiteaBot GiteaBot added topic/gitea-actions related to the actions of Gitea type/bug labels Mar 1, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 1, 2024
@GiteaBot GiteaBot added this to the 1.21.8 milestone Mar 1, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 1, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 1, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 1, 2024
@silverwind silverwind merged commit 8d08558 into go-gitea:release/v1.21 Mar 1, 2024
27 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees

@sillyguodong sillyguodong

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/gitea-actions related to the actions of Gitea type/bug
Projects
None yet
Milestone
1.21.8
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @lunny @silverwind @sillyguodong