Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect button CSS usages #29015

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Conversation

wxiaoguang
Copy link
Contributor

Fix 2 problems:

  1. Remove the legacy (non-existing) CSS: class="btn btn-gray btn-radius"
  2. Remove the button styles inside the ui message, according to: https://fomantic-ui.com/collections/message.html , the button shouldn't have any border/padding.

Before

image

image

After

image

image

@wxiaoguang wxiaoguang added type/enhancement An improvement of existing functionality backport/v1.21 This PR should be backported to Gitea 1.21 labels Feb 1, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 1, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 1, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Feb 1, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 1, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 1, 2024
@jolheiser jolheiser enabled auto-merge (squash) February 1, 2024 21:01
@jolheiser jolheiser added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 1, 2024
@jolheiser jolheiser merged commit e6265cf into go-gitea:main Feb 1, 2024
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 1, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Feb 1, 2024
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Feb 1, 2024
silverwind pushed a commit that referenced this pull request Feb 2, 2024
@wxiaoguang wxiaoguang deleted the fix-incorrect-btn branch February 2, 2024 01:42
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 2, 2024
* giteaofficial/main:
  Wrap contained tags and branches again (go-gitea#29021)
  Avoid sending update/delete release notice when it is draft (go-gitea#29008)
  Fix incorrect button CSS usages (go-gitea#29015)
  Strip trailing newline in markdown code copy (go-gitea#29019)
  Improve user search display name (go-gitea#29002)
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants