Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show whether a PR is WIP inside popups #28975

Merged
merged 6 commits into from
Feb 4, 2024
Merged

Show whether a PR is WIP inside popups #28975

merged 6 commits into from
Feb 4, 2024

Conversation

bramhaag
Copy link
Contributor

@bramhaag bramhaag commented Jan 29, 2024 •
edited
Loading

Fixes https://codeberg.org/forgejo/forgejo/issues/2257

Draft status of a PR is currently not exposed by the API. This PR adds a 'draft' field to pull requests in the API, which is used to correctly set the PR color/icon in a ContextPopup.

Before:
image

After:
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 29, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 29, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/frontend labels Jan 29, 2024
lunny
lunny reviewed Jan 29, 2024
View reviewed changes
modules/structs/issue.go Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 29, 2024
@bramhaag bramhaag force-pushed the draft-indicator branch 2 times, most recently from 7678d44 to 15a33a9 Compare January 29, 2024 15:29
@bramhaag bramhaag changed the title Show PR draft status in ContextPopup Show PR WIP status in ContextPopup Jan 29, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 29, 2024
@lunny lunny added this to the 1.22.0 milestone Jan 29, 2024
delvh
delvh requested changes Jan 29, 2024
View reviewed changes
modules/structs/issue.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 29, 2024
@bramhaag bramhaag requested a review from delvh February 1, 2024 10:14
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Feb 4, 2024
@delvh delvh changed the title Show PR WIP status in ContextPopup Include whether a PR is WIP inside popups Feb 4, 2024
@delvh delvh changed the title Include whether a PR is WIP inside popups Show whether a PR is WIP inside popups Feb 4, 2024
@delvh delvh added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Feb 4, 2024
@lafriks lafriks enabled auto-merge (squash) February 4, 2024 22:14
@lafriks lafriks merged commit 50f55f1 into go-gitea:main Feb 4, 2024
25 checks passed
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 5, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
95e4342 
* giteaofficial/main:
  [skip ci] Updated licenses and gitignores
  Show whether a PR is WIP inside popups  (go-gitea#28975)
  Unify password changing and invalidate auth tokens (go-gitea#27625)
  Unify user update methods (go-gitea#28733)
  Do not render empty comments (go-gitea#29039)
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@bramhaag @silverwind
Show whether a PR is WIP inside popups (go-gitea#28975)
1242061 
Fixes https://codeberg.org/forgejo/forgejo/issues/2257

Draft status of a PR is currently not exposed by the API. This PR adds a
'draft' field to pull requests in the API, which is used to correctly
set the PR color/icon in a ContextPopup.

---

Before:

![image](https://github.com/go-gitea/gitea/assets/5541521/72cbd30e-1175-4338-aa97-ac99c46c5118)

After:

![image](https://github.com/go-gitea/gitea/assets/5541521/111c9eba-460e-4d57-bcca-23a151c3a4f1)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@jolheiser jolheiser jolheiser left review comments

@lafriks lafriks lafriks approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
7 participants
@bramhaag @lunny @lafriks @KN4CK3R @jolheiser @delvh @GiteaBot