Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Retry button when creating a mirror-repo fails #26228

Merged
merged 23 commits into from
Aug 4, 2023
Merged

Add Retry button when creating a mirror-repo fails #26228

merged 23 commits into from
Aug 4, 2023

Conversation

kerwin612
Copy link
Member

@kerwin612 kerwin612 commented Jul 29, 2023 •
edited by lunny
Loading

fixed #26156

  • Added a retry button in the frontend (only displayed when the status is abnormal)
  • After clicking Retry, the backend adds the task back to the task queue

7UJDNM671RI})EA8~~XPL39
T83F1WL9)VGHR@MB956$VT9

@GiteaBot
Copy link
Contributor

@kerwin612 I noticed you've updated the locales for non-English languages. These will be overwritten during the sync from our translation tool Crowdin. If you'd like to contribute your translations, please visit https://crowdin.com/project/gitea. Please revert the changes done on these files. 🍵

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 29, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 29, 2023
puni9869
puni9869 reviewed Jul 29, 2023
View reviewed changes
routers/web/web.go Outdated Show resolved Hide resolved
@kerwin612
Copy link
Member Author

In order to avoid waiting for each other, I would like to ask this PR who also need to review, or I need to do what changes?

@lunny lunny added the type/enhancement An improvement of existing functionality label Jul 31, 2023
@lunny lunny added this to the 1.21.0 milestone Jul 31, 2023
@puni9869
Copy link
Member

puni9869 commented Jul 31, 2023 •
edited
Loading

I have quick question which is out of this PR context @wxiaoguang do we have debouncing implemented in frontend code?

@wxiaoguang
Copy link
Contributor

Ii have quick question which is out of this PR context @wxiaoguang do we have debouncing implemented in frontend code?

For link-action and form-fetch-action: yes. They can be tested on the devtest page.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 31, 2023
@GiteaBot GiteaBot removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 31, 2023
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Jul 31, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 1, 2023
@delvh delvh changed the title Retry is supported when the creation of a mirror-repo fails Add Retry button when creating a mirror-repo fails Aug 1, 2023
@yardenshoham yardenshoham removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 1, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 2, 2023
@puni9869
Copy link
Member

puni9869 commented Aug 3, 2023

image

@kerwin612 some checks are failing.

@kerwin612
Copy link
Member Author

image @kerwin612 some checks are failing.

image
image
This error doesn't seem to be due to my changes, but rather to the GiteaBot's merging exception. Do you want me to take care of it?

@lunny
Copy link
Member

lunny commented Aug 3, 2023

It comes from Golang versions that are outdated. We just need to wait upstream to resolve the problems.

@lunny lunny merged commit 865d222 into go-gitea:main Aug 4, 2023
23 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 4, 2023
@kerwin612 kerwin612 deleted the patch-2 branch August 4, 2023 02:35
@delvh delvh added type/feature Completely new functionality. Can only be merged if feature freeze is not active. and removed type/enhancement An improvement of existing functionality labels Aug 4, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CaiCandong CaiCandong CaiCandong left review comments

@delvh delvh delvh left review comments

@puni9869 puni9869 puni9869 approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

Add a quick retry entry when creating an mirror repository fails
8 participants
@kerwin612 @GiteaBot @puni9869 @wxiaoguang @lunny @CaiCandong @delvh @yardenshoham