Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View pull request 500 #9914

Closed
lunny opened this issue Jan 21, 2020 · 4 comments · Fixed by #9927
Closed

View pull request 500 #9914

lunny opened this issue Jan 21, 2020 · 4 comments · Fixed by #9927
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself type/bug

Comments

@lunny
Copy link
Member

lunny commented Jan 21, 2020

In a migrated repository, some pull request pages return 500 when view the page.

2020/01/21 20:53:09 ...vices/pull/update.go:67:GetDiverging() [T] PushToBaseRepo[11]: pushing commits to base repo 'refs/pull/661/head'
2020/01/21 20:53:09 routers/repo/pull.go:348:PrepareViewPullInfo() [E] GetDiverging: exit status 128 - fatal: ambiguous argument 'master..unknown repository': unknown revision or path not in the working tree.
	Use '--' to separate paths from revisions, like this:
	'git <command> [<revision>...] -- [<file>...]'
	
2020/01/21 20:53:09 ...s/context/context.go:139:HTML() [D] Template: status/500
@lunny lunny added the type/bug label Jan 21, 2020
@6543
Copy link
Member

6543 commented Jan 21, 2020

think this is caused by #9784

look's like a reference is missing :(

maby GetDiverging Link should check if HeadBranch != "" ? but this should be not be the case for a correct PR either ...

@6543
Copy link
Member

6543 commented Jan 21, 2020

so maby there is a issue with migration witch drop some needed information

@6543
Copy link
Member

6543 commented Jan 21, 2020

@lunny how to reproduce?

@lunny
Copy link
Member Author

lunny commented Jan 21, 2020

The head repository or head branch maybe deleted before merged. I think that's the problem. This should be a regression.

@lunny lunny added the issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself label Jan 21, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself type/bug
Projects
None yet
2 participants