Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom fonts URL on fomantic #9562

Closed
lunny opened this issue Dec 31, 2019 · 5 comments · Fixed by #9561
Closed

Custom fonts URL on fomantic #9562

lunny opened this issue Dec 31, 2019 · 5 comments · Fixed by #9561
Labels
type/enhancement An improvement of existing functionality

Comments

@lunny
Copy link
Member

lunny commented Dec 31, 2019

Currently, fomantic will load fonts from https://fonts.googleapis.com/css?family=Lato:400,700,400italic,700italic&subset=latin&display=swap. That should be configurable.

@lunny lunny added the type/enhancement An improvement of existing functionality label Dec 31, 2019
@bagasme
Copy link
Contributor

bagasme commented Dec 31, 2019

@lunny Can the config be stored @ app.ini?

@silverwind
Copy link
Member

All assets should be served locally, with the only exception being Gravatar avatars (unfortunately).

@lunny
Copy link
Member Author

lunny commented Jan 1, 2020

I have sent a PR #9561 to use npm to build fomantic at first.

@bagasme
Copy link
Contributor

bagasme commented Jan 1, 2020

@lunny Why npm first?

@lunny
Copy link
Member Author

lunny commented Jan 1, 2020

@bagasme I have disabled google fonts on #9561. Because we used minified js/css of fomantic we should not change it. So we have to build fomantic from the source.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants