Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide old Reactions wich are no longer Allowed #9286

Closed
6543 opened this issue Dec 7, 2019 · 9 comments · Fixed by #9387
Closed

Hide old Reactions wich are no longer Allowed #9286

6543 opened this issue Dec 7, 2019 · 9 comments · Fixed by #9387
Labels
type/enhancement An improvement of existing functionality
Milestone

Comments

@6543
Copy link
Member

6543 commented Dec 7, 2019

This issue colect options of the gitea communety about title topic

@6543 6543 mentioned this issue Dec 7, 2019
16 tasks
@guillep2k
Copy link
Member

IMHO the only reason to remove a reaction type is because it's causing problems. So, the reaction itself should disappear from the history if that's the case. Having said that, I don't like that idea; I'd rather let the admin have some moderating tools to manage that, but we don't want Gitea to become a social network (and it's a lot of work to do that properly), so... Tough choice.

@jolheiser
Copy link
Member

I think if possible it'd be better to leave the DB intact and just not display it.
Then, if an admin decides to revert it later (or it was a mistake in the first place) they will display again.

@6543
Copy link
Member Author

6543 commented Dec 8, 2019

I created an poll: :D

EDIT: poll freezed after 9days ... stats:

Poll at 2019-12-17 16-16-33

@6543
Copy link
Member Author

6543 commented Dec 8, 2019

My opinion is: still let old reaction untoched but only allow deletion if not alowed one ...
If a reaction is realy so harmfull a DELETE FROM reaction WHERE Type like "harmefull" can solve that problem ...

@6543
Copy link
Member Author

6543 commented Dec 9, 2019

@go-gitea/maintainers poll your option if you have not ... and then wee will see :)

@6543
Copy link
Member Author

6543 commented Dec 9, 2019

The poll is clear about this ... I'll send a PR

EDIT: not now ... still ongoing discusion

@6543 6543 changed the title [Discusion] Display Old reactions wich are no longer Allowed (y/n) Hide old Reactions wich are no longer Allowed Dec 9, 2019
@lunny
Copy link
Member

lunny commented Dec 11, 2019

We should have a more accurate meaning about the config.

; All available reactions. Allow users react with different emoji's
: For the whole list look at https://gitea.com/gitea/gitea.com/issues/8
REACTIONS = +1, -1, laugh, hooray, confused, heart, rocket, eyes

There are two meaning about REACTIONS. One is what reactions you will see, another is what reactions you can use. Most of the time they are the same. But when you change it serval times, it will not.

Or maybe we should have two options here. :)

@6543
Copy link
Member Author

6543 commented Dec 17, 2019

@lunny about secound setting option:

  • think this will be rare used
  • can iretate ...

@6543
Copy link
Member Author

6543 commented Dec 17, 2019

PR is here: #9387

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Dec 18, 2019
@lafriks lafriks added this to the 1.11.0 milestone Dec 18, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants