Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Add params to milestone API with order #6384

Closed
mmarif4u opened this issue Mar 20, 2019 · 6 comments · Fixed by #7131
Closed

[API] Add params to milestone API with order #6384

mmarif4u opened this issue Mar 20, 2019 · 6 comments · Fixed by #7131
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Milestone
1.9.0

Comments

@mmarif4u
Copy link

Current milestone API return both closed and open milestones, /repos/{owner}/{repo}/milestones.

It would be useful if it accept params to filter close and open milestones easily with order will be plus.
Open:
/repos/{owner}/{repo}/milestones?status=open&order=desc

Closed:
/repos/{owner}/{repo}/milestones?status=close&order=desc
@lunny lunny added type/enhancement An improvement of existing functionality modifies/api This PR adds API routes or modifies them labels Mar 20, 2019
@stale stale bot added the issue/stale label May 19, 2019
@techknowlogick techknowlogick added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/stale labels May 19, 2019
@go-gitea go-gitea deleted a comment from stale bot May 19, 2019
@esfraner
Copy link

esfraner commented Jun 3, 2019

Is it currently possible to get closed milestones by using API? I have tried with ?state=closed, and
?status=closed but without luck 😢

I am using latest from master.

@adelowo
Copy link
Member

adelowo commented Jun 3, 2019

Don’t think that’s possible yet as no one has worked on this

@esfraner
Copy link

esfraner commented Jun 3, 2019

Don’t think that’s possible yet as no one has worked on this

Thanks for your fast reply 😄

@adelowo
Copy link
Member

adelowo commented Jun 4, 2019 •
edited
Loading

@mmarif4u I just checked and that endpoint returns only opened milestones since #5051 .

@esfraner I will make a PR to add the state params to the API like that of GitHub

See https://developer.github.com/v3/issues/milestones/#list-milestones-for-a-repository and #5051 (comment)

@esfraner
Copy link

esfraner commented Jun 5, 2019

Thank you so much for everything 😄

@adelowo adelowo mentioned this issue Jun 5, 2019
Merged
@adelowo
Copy link
Member

adelowo commented Jun 5, 2019

Done @esfraner .. See #7131

@lunny lunny added this to the 1.9.0 milestone Jun 6, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

Add state param to milestone listing API adelowo/gitea
5 participants
@lunny @techknowlogick @mmarif4u @adelowo @esfraner