Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown checkboxes in tables #5875

Open
2 of 7 tasks
ghost opened this issue Jan 28, 2019 · 11 comments
Open
2 of 7 tasks

Markdown checkboxes in tables #5875

ghost opened this issue Jan 28, 2019 · 11 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug

Comments

@ghost
Copy link

ghost commented Jan 28, 2019

Description

Checkboxes inside markdown tables are not rendered as checkboxes. See https://try.gitea.io/transferkraM/markdown-checkbox-table.

@lunny lunny added the type/bug label Feb 7, 2019
@zamiere
Copy link

zamiere commented Feb 20, 2019

Another issue is the dots before the checkboxes. Put an inline "list-style-type: none" on these elements.

@stale
Copy link

stale bot commented Apr 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 21, 2019
@ghost
Copy link
Author

ghost commented Apr 23, 2019

Push.

@stale stale bot removed the issue/stale label Apr 23, 2019
@lafriks lafriks added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Apr 23, 2019
@grayminds
Copy link

^bump

@lunny
Copy link
Member

lunny commented Jan 17, 2020

I think this has been fixed since we use goldmark. Also see the original link https://try.gitea.io/transferkraM/markdown-checkbox-table

@lunny lunny closed this as completed Jan 17, 2020
@guillep2k
Copy link
Member

I think this has been fixed since we use goldmark. Also see the original link https://try.gitea.io/transferkraM/markdown-checkbox-table

@lunny I don't see this fixed. I expect to see checkboxes inside the table.

@lunny lunny reopened this Jan 17, 2020
@maria-lau
Copy link

A couple things I've noticed:

  1. I can't interact with checkboxes in a PR. (e.g. I can't click on it to mark it done)
  2. Checkboxes are rendered with a bullet (it normally isn't rendered with one, see example below)
    • task 1
    • task 2

@michaesc
Copy link

This bug is present in Gitea 1.11.4, and it's rather annoying. I confirm that the flaws @maria-lau stated regarding interaction and nonstandard (redundant) bullet symbols are present in the most recent release, according to changelogs since 1.11.4.

Note

It's possible that the release candidate tagged v1.12.0-rc1 solves the problem, with respect to #10798 (Completely fix task-list checkbox styling.) Nevertheless the release candidate is not a release, and it's unclear if the bug #10798 solves this problem as well.

@zeripath
Copy link
Contributor

I cannot find the spec that describes how checkboxes are supposed to work in tables. GFM doesn't appear to have these:

inside table

checkboxes description
[ ] unchecked
[x] checked

I have fixed the appearance of normal checkboxes in #10798 - I haven't backported them as we're in the midst of prepping for 1.12 - feel free however to make your own PR.

In terms of making these clickable and submittable - this is not supported as yet. Again PRs are welcome but it's not a simple thing to make work.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 13, 2022

GitHub

Task Time required Assigned to Current Status Finished
Calendar Cache > 5 hours in progress - [x] ok?
Object Cache > 5 hours in progress [x] item1
[ ] item2
Object Cache > 5 hours in progress
  • item1
  • item2
Object Cache > 5 hours in progress
  • item1
  • item2
  • works
  • works too

Gitea

image

@davama
Copy link

davama commented Jan 5, 2024

This would be a great feature!
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Development

No branches or pull requests

10 participants