Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit Diff page always shows status for current default branch #5649

Closed
2 of 7 tasks
apricote opened this issue Jan 6, 2019 · 0 comments · Fixed by #5650
Closed
2 of 7 tasks

Commit Diff page always shows status for current default branch #5649

apricote opened this issue Jan 6, 2019 · 0 comments · Fixed by #5650
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone

Comments

@apricote
Copy link
Contributor

apricote commented Jan 6, 2019

Description

The commit diff page always show the commit (ci) status for the default branch instead of the commit being shown.

Screenshots

Taken from the reproduction repo: https://try.gitea.io/apricote/commit-page-status/commit/c2796b0b26c389b7db1f58f2d772f780bac73991

Two commits:

gitea_commit_page_status_graph

The current HEAD of the master branch is marked as a failure, the other non-master commit is marked is success:

gitea_commit_page_status_commits

The commit page for the non-master branch wrongly shows that the commit failed, also links to the wrong commit status target url:

gitea_commit_page_status_page

@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels Jan 6, 2019
@lafriks lafriks added this to the 1.7.0 milestone Jan 6, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants