LICENSE texts are are not correctly formatted

[tastytea]

• Gitea version (or commit ref): 1.6.1
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant

Description

When I add a new repository and select a license, the LICENSE file is missing space and double-newlines, at least for GPL-2.0-only, GPL-3.0-only, GPL-3.0-or-later and BSD-4-Clause.

The GPL-3.0 licenses are also having a corrupted URL in line 3.

Correctly formatted GPL-3.0 license: https://www.gnu.org/licenses/gpl-3.0.txt

Screenshots

[zeripath]

Hmm... I'm not sure that the formatting is necessarily incorrect. All of the other licenses in options/license are similarly formatted. I'll put a PR in to fix the urls though.

[tastytea]

It may not be technically incorrect, but it is hard to read for humans and I don't see any advantage.

[techknowlogick]

@zeripath this is the script that pulls the latest license files from the SPDX repo:

gitea/scripts/generate-licenses.go

Line 20 in 801843b

func main() {

[zeripath]

Heya @tastytea , so the issue with the url is coming from our upstream ( https://github.com/spdx/license-list-data ) - please could you open an issue there?

They've changed their formatting to match your preferred style - which I agree is nicer - so I've run our update script (go run scripts/generate-licenses.go) and added a PR for this #5558.

[tastytea]

I've reported the issue upstream.

[techknowlogick]

Closing this issue as PR has been merged.