Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade gopkg.in/testfixtures.v2 #4998

Closed
typeless opened this issue Oct 2, 2018 · 3 comments · Fixed by #4999
Closed

Upgrade gopkg.in/testfixtures.v2 #4998

typeless opened this issue Oct 2, 2018 · 3 comments · Fixed by #4999

Comments

@typeless
Copy link
Contributor

typeless commented Oct 2, 2018

Encountered a deadlock while working on #2040

See https://github.com/go-gitea/gitea/blob/master/vendor/gopkg.in/testfixtures.v2/sqlite.go#L25-L40
tx.Rollback is missing. It has been fixed upstream.
I cannot find the document about upgrading the vendored packages. It used to be govendor. I am not sure about the current approach so here is the issue. Hopefully you guys could help.
@adelowo
Copy link
Member

adelowo commented Oct 2, 2018 •
edited

make vendor

gitea/Makefile

Line 176 in b8d048f

vendor:

@typeless
Copy link
Contributor Author

typeless commented Oct 2, 2018 •
edited

@adelowo Thanks for the hint. I am looking up dep now.

hmm ... make vendor has been hanging for quite a while. Is that normal? I should have added -v 😆

@typeless typeless mentioned this issue Oct 2, 2018
Merged
@adelowo
Copy link
Member

adelowo commented Oct 2, 2018

hmm ... make vendor has been hanging for quite a while. Is that normal? I should have added -v 😆

Usually slow on my end too but I think it's my internet connection

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade gopkg.in/testfixtures.v2 typeless/gitea
2 participants
@typeless @adelowo