Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-SVG image links don't link to intended website #4569

Closed
1 of 4 tasks
Eisfunke opened this issue Jul 31, 2018 · 1 comment · Fixed by #4675
Closed
1 of 4 tasks

Non-SVG image links don't link to intended website #4569

Eisfunke opened this issue Jul 31, 2018 · 1 comment · Fixed by #4675
Labels
Milestone

Comments

@Eisfunke
Copy link
Contributor

Eisfunke commented Jul 31, 2018

  • Gitea version (or commit ref): Tested on 1.2.3 and 40bbc73
  • Operating system: Tested on Ubuntu 16.04.5 LTS and Arch Linux
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    Seems down, so I can't check.

Description

When embedding an image with a link like this
[![test](https://img.shields.io/badge/test-yes-green.svg)](https://example.org)
in a markdown file in Gitea, it correctly shows as the image and links to the intended website.

Though when the linked image is not an svg, like this
[![test](https://img.shields.io/badge/test-no-red.png)](https://example.org)
it doesn't link to the intended website, but only to the image itself.

You can see it here: https://git.eisfunke.com/Eisfunke/test/src/branch/master/README.md

On Github it works: https://github.com/Eisfunke/test/blob/master/README.md

@mappu
Copy link
Contributor

mappu commented Oct 6, 2018

I can confirm this issue still affects 1.5.1.

Markdown content like [![](doc/image.thumb.png)](doc/image.png) creates a link to image.thumb.png, not image.png.

@lunny lunny added the type/bug label Oct 6, 2018
@lafriks lafriks added this to the 1.7.0 milestone Oct 30, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants