-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LDAP user synchronization timeout disables all users #4402
Labels
issue/confirmed
Issue has been reviewed and confirmed to be present or accepted to be implemented
topic/authentication
type/bug
Comments
7 tasks
This was referenced Aug 22, 2018
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions. |
same problem! help wanted. |
7 tasks
lunny
added
the
issue/confirmed
Issue has been reviewed and confirmed to be present or accepted to be implemented
label
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
issue/confirmed
Issue has been reviewed and confirmed to be present or accepted to be implemented
topic/authentication
type/bug
[x]
):Description
I've notcied that if the LDAP user sync runs into a timeout all users tied to that authentication source will be disabled.
While I understand the reasoning from a security perspective it might be sensible to at least do one or two retries because this otherwise might bring down the entire system until this is noticed.
The issue making this worse is that in case users are decativated the behaviour is not consistent. Assume the following:
Suggestion
As also in a perfectly working environment there can be a temporary unavailability of the LDAP server that was chosen by Gitea to perform user sync temporary failurs (like Timeout or unable to connect) should not lead to immediate user deactivation but the sync should be retried 2 or 3 times, possibly with a delay of a few minutes
The text was updated successfully, but these errors were encountered: