Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown parsing incorrectly for video links #3845

Closed
coolaj86 opened this issue Apr 23, 2018 · 3 comments
Closed

Markdown parsing incorrectly for video links #3845

coolaj86 opened this issue Apr 23, 2018 · 3 comments
Labels

Comments

@coolaj86
Copy link
Contributor

coolaj86 commented Apr 23, 2018

Gitea version 1.4.0

Go version 1.1.0

This snippet in the README.md should create an image that links to the YouTube video:

[![Free SSL with Greenlock.js](https://i.imgur.com/Y8ix6Ts.png)](https://youtu.be/e8vaR4CEZ5s)

Like this:

Free SSL with Greenlock.js

Instead it creates an <a> tag with an empty string that cannot be clicked on for the YouTube video and a second link to the picture, which links to the picture itself.

Example:

https://git.coolaj86.com/coolaj86/greenlock-express.js/src/commit/dfabdd15dd04742a7af296b70ad84d674f956953/README.md

@coolaj86
Copy link
Contributor Author

coolaj86 commented Apr 23, 2018

This commit on my own gitea instance demonstrates that the link is parsed incorrectly.

@lunny lunny added the type/bug label Apr 24, 2018
@lunny lunny added this to the 1.x.x milestone Apr 24, 2018
@laoshaw
Copy link

laoshaw commented Nov 14, 2018

Just found out this bug, it's impractical to embed any video without fixing this, as shown a pic for the video is very helpful.

@laoshaw
Copy link

laoshaw commented Dec 2, 2018

@coolaj86 gitea 1.6.0 seems fixed this, I can click on the image then it jumps to youtube and starts playing.

still, if you self-host the video, you need click on the image to see the video, then click on the video to play it, it would be nice if I can play the video with one click though

@lunny lunny closed this as completed Dec 9, 2018
@lunny lunny removed this from the 1.x.x milestone Dec 9, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants