Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Show changes since your last review" button should still show even if a review was requested from me again #31423

Open
Gr3q opened this issue Jun 19, 2024 · 0 comments
Labels

Comments

@Gr3q
Copy link

Gr3q commented Jun 19, 2024

Description

A PR "Files Changed" tab's "Filter by commit" button's "Show changes since your last review" sub button should still show even if a review was requested from me again after my review. Not that the previous review was not dismissed.

My guess is that the logic only looks at the top of the review stack of a person, and when a request is on top it just skips the part where it works out the difference.

Gitea Version

1.21.11

Can you reproduce the bug on the Gitea demo site?

No, because I need 2 account for that, but I'll do that when I have time.

Log Gist

No response

Screenshots

Before a new review was requested of me

20240619_18h04m14s_grim
20240619_18h04m04s_grim

After a new review was requested of me

20240619_18h07m48s_grim
20240619_18h07m55s_grim

Git Version

No response

Operating System

Ubuntu 22.04

How are you running Gitea?

self-hosted docker image

Database

None

@Gr3q Gr3q added the type/bug label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant