Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The information in commit detail page was incorrect #11709

Closed
2 of 7 tasks
L0veSunshine opened this issue May 31, 2020 · 2 comments
Closed
2 of 7 tasks

[BUG] The information in commit detail page was incorrect #11709

L0veSunshine opened this issue May 31, 2020 · 2 comments

Comments

@L0veSunshine
Copy link
Contributor

Description

When you visit a commit's detail page, if this commit is a merge opeation. The information on the page was a bit incorrect.
As you can see in this screenshot:
The parent commit is incorrect.
image

Screenshots

@CirnoT
Copy link
Contributor

CirnoT commented May 31, 2020

What exactly do you mean by that?
The commit 7f0689524f2132cd52042f53eee93c43778358b8 has two parents: 29756511f3f3c2e32a7d89bb051a2494cc942211 and a4afa5fbc2fe9e6fea17788975987cf6faab382f

You should get same result by doing git log -1 7f0689524f2132cd52042f53eee93c43778358b8

commit 7f0689524f2132cd52042f53eee93c43778358b8
Merge: 2975651 a4afa5f
Author: M M Arif <[email protected]>
Date:   Fri May 15 22:08:29 2020 +0000

    Merge pull request 'Add corners to popup dialogs' (#495) from ui-enhancements into master

    Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/495
    Reviewed-by: opyale <[email protected]>

chrome_2020-05-31_22-55-23

@L0veSunshine
Copy link
Contributor Author

What exactly do you mean by that?
The commit 7f0689524f2132cd52042f53eee93c43778358b8 has two parents: 29756511f3f3c2e32a7d89bb051a2494cc942211 and a4afa5fbc2fe9e6fea17788975987cf6faab382f

You should get same result by doing git log -1 7f0689524f2132cd52042f53eee93c43778358b8

commit 7f0689524f2132cd52042f53eee93c43778358b8
Merge: 2975651 a4afa5f
Author: M M Arif <[email protected]>
Date:   Fri May 15 22:08:29 2020 +0000

    Merge pull request 'Add corners to popup dialogs' (#495) from ui-enhancements into master

    Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/495
    Reviewed-by: opyale <[email protected]>

chrome_2020-05-31_22-55-23

I am very sorry for the late reply.
After checking about this again, i confirm you are right, that is only a ui issue.
Thanks for your pr!

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants