Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS File Path Options for MySQL Database Connection #10828

Open
bagasme opened this issue Mar 26, 2020 · 2 comments
Open

Add TLS File Path Options for MySQL Database Connection #10828

bagasme opened this issue Mar 26, 2020 · 2 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality

Comments

@bagasme
Copy link
Contributor

bagasme commented Mar 26, 2020

Description

Currently connecting Gitea to MySQL database over TLS only supports one-way TLS, (that is only database server can be verified by TLS). To enable two-way TLS (both client and server can be verified), passing client credentials (client certificate, its private key, and CA certificates) are required. This can be accomplished by defining custom tls.Config handler as per driver documentation.

Path to client credentials should be added to app.ini. The corresponding app.ini entry, SSL_MODE must be set to verify-client (tls.Config custom handler) to enable this option.

@lunny lunny added the type/enhancement An improvement of existing functionality label Mar 26, 2020
@stale
Copy link

stale bot commented May 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label May 25, 2020
@zeripath zeripath added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label May 25, 2020
@stale stale bot removed the issue/stale label May 25, 2020
@mshedsilegx
Copy link

Can that be considered to be implemented ? it is a blocker for us as our mysql server is configured with 2-way TLS (due to our security policy):

  • Require trusted client certificates
    • Only allows connections from clients that use a valid client certificate and SSL encryption

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants