Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refit not allowed #382

Open
GJBoth opened this issue Jun 22, 2020 · 4 comments
Open

Refit not allowed #382

GJBoth opened this issue Jun 22, 2020 · 4 comments

Comments

@GJBoth
Copy link

GJBoth commented Jun 22, 2020

Hi,

Thanks for your package, it's very useful. I tried to fit two different datasets using the same model and I got an error that refitting is not allowed. What is the reason for this? (SK-learn doesn't prompt this.) For me its useful as I prefer not to keep lists of models with exactly the same parameters laying around...

Thanks!

@jasmainak
Copy link
Member

I think we got rid of this error. Can you check if you get the error still with the latest version or the development version?

@GJBoth
Copy link
Author

GJBoth commented Jun 23, 2020

In the new version it's indeed fixed, thanks. It hasn't been in the pip version, though. Additional question: what settings do I need to reproduce scikit-learn Lasso results? I'm struggling to get the same result on the same dataset. Right now I have a gaussian noise, alpha=1.0 and similar tolerance, but that doesn't work. Other methods (Celer, for example) do give the same result.

@jasmainak
Copy link
Member

did you look at the convergence plot? I think our solvers are not as efficient / optimized as celer or scikit-learn. You might be running out iterations.

@jasmainak
Copy link
Member

@GJBoth is this still relevant for you? You might want to use the latest version to see if it fixes the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants