Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement sample weights to allow use on weighted data #279

Open
ghost opened this issue Mar 7, 2019 · 7 comments
Open

implement sample weights to allow use on weighted data #279

ghost opened this issue Mar 7, 2019 · 7 comments

Comments

@ghost
Copy link

ghost commented Mar 7, 2019

Proof-of concept is in https://github.com/peterfoley605/pyglmnet/tree/implement_sample_weight

@jasmainak
Copy link
Member

Feel free to open a WIP pull request so that it's not too much to review in one go

@ghost
Copy link
Author

ghost commented Mar 7, 2019

tricky thing there is that the branch is built as a "fork of pyglmnet that does things the way I need them done" rather than a "prepping for a PR", and it includes additional logging along with the sample weights, so it probably wouldn't be possible to merge directly. It does have tests and updated documentation and everything, though.

@jasmainak
Copy link
Member

okay I see, whenever you are ready.

It's usually a good idea to open PR earlier than later so that it's possible to discuss and change things while there isn't too much code.

@arkottke
Copy link

It's unfortunate that the original user account on this request was deleted. I would also be interested in this feature.

@jasmainak
Copy link
Member

it's here: #324

I am happy to review/help if you want to try and finish this work ... however it's unlikely to be on the top of my priority list at the moment

@arkottke
Copy link

Oh great! I will see if I can carve out some time to contribute to this.

@jasmainak
Copy link
Member

keep us posted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants