Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake8 on tests #271

Open
jasmainak opened this issue Sep 14, 2018 · 2 comments
Open

flake8 on tests #271

jasmainak opened this issue Sep 14, 2018 · 2 comments
Labels
Milestone

Comments

@jasmainak
Copy link
Member

The flake8 linter doesn't seem to be working on the test directory. @pavanramkumar did we disable it at some point? In any case, we should fix this as soon as possible ...

@jasmainak jasmainak added this to the version 0.2 milestone Sep 14, 2018
@pavanramkumar
Copy link
Collaborator

is this simply a case of adding this line to travis.yml:

flake8 --count tests

seems to pass locally except for some docstring complaints

@jasmainak
Copy link
Member Author

I think the issue is that it's not complaining when there is a pull request. Try making a pull request where you make flake8 errors in tests/ and Travis does not complain ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants