Drag & drop is broken

[marcwieland95]

I just noticed that there's an issue even on the documentation page with the drag & drop.

The element is lost and can't be moved after some mouse interactions. I'm not sure on which exact behaviour this is happening.

Is this issue already known? For me, it looks like it's quite critical and a basic behaviour which sould work. I can dig into the code and debug. But first I wanted to hear if there are already some ideas on the issue.

Browser: Chrome 71.0 (but I tried also on other browsers)
OS: MacOS 10.14.2

[av01d]

Confirmed on Firefox 65 for OSX as well. And Chrome 72/OSX has the same problem, as does MS Edge on Windows.

[lifeinchords]

I think this is what I'm referencing as well in #309

[marcwieland95]

Did someone already some research regarding this issue? I'm using version 3 for the first time and I'm not familiar with the source code yet.

[jedrzejchalubek]

I've made some research about this issue and it looks like it may be caused by incorrect deletion of swiping events on dragging. removeEventListener do not receive the same capture argument as on addEventListener. Ref cb74a3a

Tagged new v3.2.6 release. It would be great if someone could give a test with this version.

[marcwieland95]

I can give it a try tomorrow.

[marcwieland95]

I updated GlideJS to versioh 3.2.6. But sadly I can't see any changes regarding the drag & drop issue.

[omares]

Our glide implementation has the same issue and i can reproduce it on the official glidejs documentation page using Firefox 65.0.1 (64-bit) on mac.

[omares]

I started to investigate the issue and it looks like this is related to the moveable flag/logic inside swipe.js.

While testing i have seen that the flag is often set to false and thus preventing code #1, #2 from executing. Blatantly commenting out the set to false code seems to fix the issue.

The intention was to fix #258 but according to feedback it did not do so. My suggestion would be to remove the flag and code as it does not fix the issue and also introduces a component wide state which makes the code hard to understand and prone to side effects.

@jedrzejchalubek Would love to hear your opinion on my suggestion, as i gladly can/would apply the required changes.

[omares]

I am impatient and already created a PR #330 that includes my proposed change :)

[marcwieland95]

Thanks @omares for your pull request and your work fixing the bug by yourself.

I can confirm that the issue is fixed completely.