Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row grouping modules missing in package #958

Open
theiliad opened this issue May 31, 2024 · 5 comments
Open

Row grouping modules missing in package #958

theiliad opened this issue May 31, 2024 · 5 comments

Comments

@theiliad
Copy link

theiliad commented May 31, 2024

I've noticed that a lot of modules related to row-grouping don't seem to be included in 6.0.3 release, not sure if previous releases did in fact include those

For instance these files

image

and

image

are missing from final build
https://unpkg.com/browse/@glideapps/[email protected]/src/data-editor/

I'm also seeing type warnings suggesting that this feature might not actually be in the package
image

Also I'm not able to see any results after pulling all those modules into my local codebase, and adding rowGrouping to my grid

Is this in fact an issue?

@theiliad theiliad changed the title Row grouping not working Row grouping modules missing in package May 31, 2024
@citizensas
Copy link

If it helps, it is available in the latest alpha 6.0.4-alpha8 release.

@theiliad
Copy link
Author

If it helps, it is available in the latest alpha 6.0.4-alpha8 release.

I see, so not stable yet?

@snowy-owll
Copy link

I see, so not stable yet?

I couldn't get the row grouping to work correctly. It looks like there are problems with calculating the original row indexes in groups.

@mirus-ua
Copy link

I see, so not stable yet?

I couldn't get the row grouping to work correctly. It looks like there are problems with calculating the original row indexes in groups.

We are playing a bit with the grid for our POC, and here is a potential solution for your problem if it's the same as ours
const item = data[isGroupHeader ? originalIndex[1] : row];

@snowy-owll
Copy link

We are playing a bit with the grid for our POC, and here is a potential solution for your problem if it's the same as ours const item = data[isGroupHeader ? originalIndex[1] : row];

@mirus-ua Yes, I know about this. It helps with collapsing rows, but it returns a little wrong index. Even their example doesn't show all the data. It should display 1000 rows, but the last row index is 995. So, every group "eats" one row.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants