Git ls tree fixes #213
Merged
Git ls tree fixes #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robrix
approved these changes
Jul 31, 2019
| @@ -1,7 +1,7 @@ | |||
| cabal-version: 2.4 | |||
|
|
|||
| name: semantic | |||
| version: 0.6.0.0 | |||
| version: 0.7.0.0 | |||
There was a problem hiding this comment.
This appears to be a backwards-compatible bugfix, so I think this could be 0.6.0.1?
There was a problem hiding this comment.
I meant to bump this on #212 since that added some new cmd line args, but didn't push the commit before that PR merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the switch to attoparsec parsing of
git ls-treeoutput (see #99) we lost the ability to handle things like commit objects (used for submodules) and other valid modes. Unfortunately things fail by just returning an empty list if parsing fails so this was a little challenging to catch.This fixes the parsing and adds a test.