Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running Gin on one of its dependencies #55

Open
sandybrownlee opened this issue Aug 27, 2020 · 3 comments
Open

Running Gin on one of its dependencies #55

sandybrownlee opened this issue Aug 27, 2020 · 3 comments

Comments

@sandybrownlee
Copy link
Collaborator

If Gin is run of one of it’s dependencies (e.g. commons libraries) a linkage error occurs if a different version off the same library is used. This is to be expected as two classes with the same name are loaded to the CacheClassLoader. In this case InternalTestRunner simply should not be run: we need to confirm that it's okay with ExternalTestRunner, and then add a note on that to the README.

@GiovaniGuizzo
Copy link
Collaborator

It is somewhat OK with ExternalTestRunner. However, in some cases it still fails. Namely, when the test cases perform any kind of operation over JUnit classes (e.g. commons-lang tests for AnnotationUtils are executed over the @Test annotation).

I also experienced some issues when test cases use reflection, although I don't know exactly why.

@justynapt
Copy link
Collaborator

justynapt commented Aug 12, 2021

Encountered the same thing today (with guava dependency and com.google.truth project). -j options don't resolve this.

@justynapt
Copy link
Collaborator

for now: let's put in documentation that strange things might happen in this case, could be eventually respolved using ExternalTestRunnar later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants