Windows compile by MinGW 64 bit #347

yhmtsai · 2019-09-10T14:03:35Z

This PR makes MinGW, one of windows compiler, be able to compile the ginkgo library (shared/static).
It is part of #281

The requirement is git, mingw(64bit), and WSL.
WSL is used to run the bash to update the header automatically.

gflags library's name is gflags_nothreads_static.lib in WINDOWS
std::this_thread::sleep_for does not sleep for the duration of nanosecond. reference
The implementation depends on the compiler/system. the clock uses system_clock not steady_clock
Now, use Sleep(millisecond) in windows.h for testings. Moreover, change the clock of stop/time according to Monotonic and Adjustable Clocks #293. The picture in the end shows sleep_for doesn't work as we expect.
update_ginkgo_header.sh can handle \r in Windows.
Windows creates two files for one shared library, one is for compile and the other is for runtime.
But windows does not have rpath for runtime library searching. I add the output in the end of cmake about the settings. Users need to add them manually for run the program.

sleep_for 1 ms might only sleep 0.5 ms.

codecov · 2019-09-10T14:03:56Z

Codecov Report

Merging #347 into develop will decrease coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #347      +/-   ##
===========================================
- Coverage    98.28%   98.25%   -0.03%     
===========================================
  Files          250      246       -4     
  Lines        18718    18417     -301     
===========================================
- Hits         18397    18096     -301     
  Misses         321      321

Impacted Files	Coverage Δ
include/ginkgo/core/stop/time.hpp	`85.71% <ø> (ø)`	⬆️
reference/test/stop/time.cpp	`100% <100%> (ø)`	⬆️
reference/test/stop/combined.cpp	`100% <100%> (ø)`	⬆️
include/ginkgo/core/base/math.hpp	`93.1% <0%> (ø)`	⬆️
reference/test/factorization/par_ilu_kernels.cpp	`98.45% <0%> (ø)`	⬆️
include/ginkgo/core/factorization/par_ilu.hpp	`100% <0%> (ø)`	⬆️
cuda/base/device_guard.hpp	`100% <0%> (ø)`	⬆️
cuda/test/solver/lower_trs_kernels.cpp	`100% <0%> (ø)`	⬆️
cuda/test/solver/upper_trs_kernels.cpp
include/ginkgo/core/preconditioner/ilu.hpp
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b6c44...19b4de6. Read the comment docs.

thoasm

I don't quite understand why you want to handle the newlines separately. The echo -e "$line", however, definitively has to be changed.

CMakeLists.txt

dev_tools/scripts/update_ginkgo_header.sh

reference/CMakeLists.txt

reference/test/stop/combined.cpp

dev_tools/scripts/update_ginkgo_header.sh

reference/test/stop/combined.cpp

yhmtsai · 2019-09-18T12:31:45Z

I add the GINKGO_WINDOWS_SHARED_LIBRARY_RELPATH for windows shared library compilation only if build shared library and executable program (benchmark, example, or tests).

I change the directory due to the situation.

User builds ginkgo without CUDA and add core/device_hooks into PATH.
User builds ginkgo with CUDA and add cuda into PATH
User builds ginkgo without CUDA again and must add core/device_hooks into PATH

It leads the environment long PATH contains repeated same thing.
And make user need to modify the PATH when changing configuration of ginkgo.

Add the test for checking environment PATH.
It checks the program can load the correct library from GINKGO_WINDOWS_SHARED_LIBRARY_RELPATH even this path is the first one in PATH

thoasm

LGTM!

pratikvn

Some minor typos, otherwise looks good.

cmake/build_helpers.cmake

dev_tools/scripts/update_ginkgo_header.sh

tcojean

Some minor comments overall, which does not change functionality.

cmake/build_helpers.cmake

reference/test/stop/combined.cpp

CMakeLists.txt

…limit

The Ginkgo team is proud to announce the new minor release of Ginkgo version 1.1.0. This release brings several performance improvements, adds Windows support, adds support for factorizations inside Ginkgo and a new ILU preconditioner based on ParILU algorithm, among other things. For detailed information, check the respective issue. Supported systems and requirements: + For all platforms, cmake 3.9+ + Linux and MacOS + gcc: 5.3+, 6.3+, 7.3+, 8.1+ + clang: 3.9+ + Intel compiler: 2017+ + Apple LLVM: 8.0+ + CUDA module: CUDA 9.0+ + Windows + MinGW and CygWin: gcc 5.3+, 6.3+, 7.3+, 8.1+ + Microsoft Visual Studio: VS 2017 15.7+ + CUDA module: CUDA 9.0+, Microsoft Visual Studio + OpenMP module: MinGW or CygWin. The current known issues can be found in the [known issues page](https://github.com/ginkgo-project/ginkgo/wiki/Known-Issues). Additions: + Upper and lower triangular solvers ([#327](#327), [#336](#336), [#341](#341), [#342](#342)) + New factorization support in Ginkgo, and addition of the ParILU algorithm ([#305](#305), [#315](#315), [#319](#319), [#324](#324)) + New ILU preconditioner ([#348](#348), [#353](#353)) + Windows MinGW and Cygwin support ([#347](#347)) + Windows Visual studio support ([#351](#351)) + New example showing how to use ParILU as a preconditioner ([#358](#358)) + New example on using loggers for debugging ([#360](#360)) + Add two new 9pt and 27pt stencil examples ([#300](#300), [#306](#306)) + Allow benchmarking CuSPARSE spmv formats through Ginkgo's benchmarks ([#303](#303)) + New benchmark for sparse matrix format conversions ([#312](#312)) + Add conversions between CSR and Hybrid formats ([#302](#302), [#310](#310)) + Support for sorting rows in the CSR format by column idices ([#322](#322)) + Addition of a CUDA COO SpMM kernel for improved performance ([#345](#345)) + Addition of a LinOp to handle perturbations of the form (identity + scalar * basis * projector) ([#334](#334)) + New sparsity matrix representation format with Reference and OpenMP kernels ([#349](#349), [#350](#350)) Fixes: + Accelerate GMRES solver for CUDA executor ([#363](#363)) + Fix BiCGSTAB solver convergence ([#359](#359)) + Fix CGS logging by reporting the residual for every sub iteration ([#328](#328)) + Fix CSR,Dense->Sellp conversion's memory access violation ([#295](#295)) + Accelerate CSR->Ell,Hybrid conversions on CUDA ([#313](#313), [#318](#318)) + Fixed slowdown of COO SpMV on OpenMP ([#340](#340)) + Fix gcc 6.4.0 internal compiler error ([#316](#316)) + Fix compilation issue on Apple clang++ 10 ([#322](#322)) + Make Ginkgo able to compile on Intel 2017 and above ([#337](#337)) + Make the benchmarks spmv/solver use the same matrix formats ([#366](#366)) + Fix self-written isfinite function ([#348](#348)) + Fix Jacobi issues shown by cuda-memcheck Tools and ecosystem: + Multiple improvements to the CI system and tools ([#296](#296), [#311](#311), [#365](#365)) + Multiple improvements to the Ginkgo containers ([#328](#328), [#361](#361)) + Add sonarqube analysis to Ginkgo ([#304](#304), [#308](#308), [#309](#309)) + Add clang-tidy and iwyu support to Ginkgo ([#298](#298)) + Improve Ginkgo's support of xSDK M12 policy by adding the `TPL_` arguments to CMake ([#300](#300)) + Add support for the xSDK R7 policy ([#325](#325)) + Fix examples in html documentation ([#367](#367))

The Ginkgo team is proud to announce the new minor release of Ginkgo version 1.1.0. This release brings several performance improvements, adds Windows support, adds support for factorizations inside Ginkgo and a new ILU preconditioner based on ParILU algorithm, among other things. For detailed information, check the respective issue. Supported systems and requirements: + For all platforms, cmake 3.9+ + Linux and MacOS + gcc: 5.3+, 6.3+, 7.3+, 8.1+ + clang: 3.9+ + Intel compiler: 2017+ + Apple LLVM: 8.0+ + CUDA module: CUDA 9.0+ + Windows + MinGW and Cygwin: gcc 5.3+, 6.3+, 7.3+, 8.1+ + Microsoft Visual Studio: VS 2017 15.7+ + CUDA module: CUDA 9.0+, Microsoft Visual Studio + OpenMP module: MinGW or Cygwin. The current known issues can be found in the [known issues page](https://github.com/ginkgo-project/ginkgo/wiki/Known-Issues). ### Additions + Upper and lower triangular solvers ([#327](#327), [#336](#336), [#341](#341), [#342](#342)) + New factorization support in Ginkgo, and addition of the ParILU algorithm ([#305](#305), [#315](#315), [#319](#319), [#324](#324)) + New ILU preconditioner ([#348](#348), [#353](#353)) + Windows MinGW and Cygwin support ([#347](#347)) + Windows Visual Studio support ([#351](#351)) + New example showing how to use ParILU as a preconditioner ([#358](#358)) + New example on using loggers for debugging ([#360](#360)) + Add two new 9pt and 27pt stencil examples ([#300](#300), [#306](#306)) + Allow benchmarking CuSPARSE spmv formats through Ginkgo's benchmarks ([#303](#303)) + New benchmark for sparse matrix format conversions ([#312](#312)) + Add conversions between CSR and Hybrid formats ([#302](#302), [#310](#310)) + Support for sorting rows in the CSR format by column idices ([#322](#322)) + Addition of a CUDA COO SpMM kernel for improved performance ([#345](#345)) + Addition of a LinOp to handle perturbations of the form (identity + scalar * basis * projector) ([#334](#334)) + New sparsity matrix representation format with Reference and OpenMP kernels ([#349](#349), [#350](#350)) ### Fixes + Accelerate GMRES solver for CUDA executor ([#363](#363)) + Fix BiCGSTAB solver convergence ([#359](#359)) + Fix CGS logging by reporting the residual for every sub iteration ([#328](#328)) + Fix CSR,Dense->Sellp conversion's memory access violation ([#295](#295)) + Accelerate CSR->Ell,Hybrid conversions on CUDA ([#313](#313), [#318](#318)) + Fixed slowdown of COO SpMV on OpenMP ([#340](#340)) + Fix gcc 6.4.0 internal compiler error ([#316](#316)) + Fix compilation issue on Apple clang++ 10 ([#322](#322)) + Make Ginkgo able to compile on Intel 2017 and above ([#337](#337)) + Make the benchmarks spmv/solver use the same matrix formats ([#366](#366)) + Fix self-written isfinite function ([#348](#348)) + Fix Jacobi issues shown by cuda-memcheck ### Tools and ecosystem improvements + Multiple improvements to the CI system and tools ([#296](#296), [#311](#311), [#365](#365)) + Multiple improvements to the Ginkgo containers ([#328](#328), [#361](#361)) + Add sonarqube analysis to Ginkgo ([#304](#304), [#308](#308), [#309](#309)) + Add clang-tidy and iwyu support to Ginkgo ([#298](#298)) + Improve Ginkgo's support of xSDK M12 policy by adding the `TPL_` arguments to CMake ([#300](#300)) + Add support for the xSDK R7 policy ([#325](#325)) + Fix examples in html documentation ([#367](#367)) Related PR: #370

yhmtsai requested review from thoasm, tcojean, hartwiganzt and pratikvn September 10, 2019 14:20

yhmtsai self-assigned this Sep 10, 2019

yhmtsai added the reg:build This is related to the build system. label Sep 10, 2019

pratikvn added the plat:windows This is related to the Windows Operating system label Sep 10, 2019

yhmtsai force-pushed the windows_compile branch from 5e02780 to 5c02607 Compare September 12, 2019 10:17

yhmtsai mentioned this pull request Sep 16, 2019

Microsoft Visual Studio Compiler Support #351

Merged

7 tasks

thoasm requested changes Sep 16, 2019

View reviewed changes

thoasm reviewed Sep 17, 2019

View reviewed changes

reference/test/stop/combined.cpp Outdated Show resolved Hide resolved

yhmtsai force-pushed the windows_compile branch from 7b21a36 to de188f2 Compare September 18, 2019 12:21

thoasm approved these changes Sep 18, 2019

View reviewed changes

pratikvn approved these changes Sep 20, 2019

View reviewed changes

cmake/build_helpers.cmake Outdated Show resolved Hide resolved

cmake/build_helpers.cmake Outdated Show resolved Hide resolved

cmake/build_helpers.cmake Outdated Show resolved Hide resolved

dev_tools/scripts/update_ginkgo_header.sh Outdated Show resolved Hide resolved

tcojean approved these changes Sep 20, 2019

View reviewed changes

tcojean added the 1:ST:ready-for-review This PR is ready for review label Sep 20, 2019

yhmtsai force-pushed the windows_compile branch from f5e10aa to 9da8f17 Compare September 20, 2019 12:54

tcojean added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Sep 23, 2019

yhmtsai added 9 commits September 23, 2019 16:46

fix update_ginkgo_header.sh on \r in Windows

65d0df9

fix gflags problem in Windows

6c354e4

Output path for linking in runtime

912d66f

add Windows sleep and use steady_clock

ea195fb

update the documentation

e672510

split context and newline interpretor and use variable to define time…

249fb58

…limit

use macro to update windows path

6a2fcc7

add windows shared custom dir and check the environment path

fdf7555

modification by comments

19b4de6

yhmtsai force-pushed the windows_compile branch from 9da8f17 to 19b4de6 Compare September 23, 2019 14:48

yhmtsai merged commit cde698f into develop Sep 23, 2019

pratikvn deleted the windows_compile branch October 20, 2019 11:40

yhmtsai mentioned this pull request Jul 23, 2020

[JOSS REVIEW] Minor documentation needed for Windows install #600

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Windows compile by MinGW 64 bit #347

Windows compile by MinGW 64 bit #347

yhmtsai commented Sep 10, 2019

codecov bot commented Sep 10, 2019 •

edited

Loading

thoasm left a comment

yhmtsai commented Sep 18, 2019

thoasm left a comment

pratikvn left a comment

tcojean left a comment

Windows compile by MinGW 64 bit #347

Windows compile by MinGW 64 bit #347

Conversation

yhmtsai commented Sep 10, 2019

codecov bot commented Sep 10, 2019 • edited Loading

Codecov Report

thoasm left a comment

Choose a reason for hiding this comment

yhmtsai commented Sep 18, 2019

thoasm left a comment

Choose a reason for hiding this comment

pratikvn left a comment

Choose a reason for hiding this comment

tcojean left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 10, 2019 •

edited

Loading