Improve the conversions benchmarks #317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some performance and result quality improvement to the
conversions benchmarks.
matrix_to
inconvert_matrix
function. This allowsto catch the related exceptions in a way similar to the other benchmarks.
matrix_to
object until the use ofcopy_from
in thewarmup. This allows to catch non-existing conversions quickly (e.g.
ELL->COO), without the overhead of loading big matrix data first.
AllocationError
related exceptions formatrix_from
and add acompleted: false
entry to the results on failure to instantiate a matrixfrom the data. This happens a lot when converting from
ELL
for example,which can take a lot of space.