Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:visible class #3

Closed
gingersoulrecords opened this issue Mar 29, 2017 · 2 comments
Closed

:visible class #3

gingersoulrecords opened this issue Mar 29, 2017 · 2 comments
Assignees

Comments

@gingersoulrecords
Copy link
Owner

I recently found this fix on the jQuery match height github

liabru/jquery-match-height#126

to ignore elements that were not visible. This is helpful with a SoulSections navigation bar, so I can equalize the heights of the elements, then use CSS to translate shorter elements to their container's center (thereby aligning all elements in a straight line).

Can we add :visible to our matchheight selectors?

Thanks,

DB

@ideag ideag self-assigned this Mar 30, 2017
@ideag
Copy link
Collaborator

ideag commented Mar 30, 2017

yeah, that is probably a good idea :)

@gingersoulrecords
Copy link
Owner Author

More on this:

I'm using the :visible selector on a site. It works fine on page load, but when the window is resized, the matchheight function needs to be called again to recognize which elements are (now) visible and which elements are not. Otherwise, it breaks the functionality and considers an 'invisible' element's height in the matching equation.

Can we please add a .resize() function to update the selectors, per liabru/jquery-match-height#60 (comment) (they're using an ajax example but we can add this to window.resize() )?

Thx

DB

@ideag ideag closed this as completed Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants