Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor plot_ppc_* #14

Open
ghurault opened this issue Sep 13, 2021 · 0 comments
Open

Refactor plot_ppc_* #14

ghurault opened this issue Sep 13, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@ghurault
Copy link
Owner

There are four functions:

  • plot_post_traj_pmf
  • plot_post_traj_fanchart
  • plot_ppc_traj_pmf
  • plot_ppc_traj_fanchart

which are very similar as they plot posterior trajectories (post) or posterior trajectories with observed data (ppc), either as a probability mass function (pmf) or as a fanchart (fanchart).
I found it would be more elegant and straightforward if we had one function and choose the plotting style and the input would determine whether it post or ppc, or something like that.

Maybe the easiest way to do it would be using OOP, cf. #5 , so some of what is different in the functions' signature get integrated into the "object".

@ghurault ghurault added the enhancement New feature or request label Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant