From 27d1431463955180e62100f2e07b1e4acdd05998 Mon Sep 17 00:00:00 2001 From: Daniele <57776841+daniandtheweb@users.noreply.github.com> Date: Sun, 2 Jun 2024 16:01:58 +0000 Subject: [PATCH 1/2] Improve hipBLAS support in CMake This improves the detection of the correct CMAKE_PREFIX_PATH when using different distributions or a self-built ROCm SDK. --- CMakeLists.txt | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 52b392a13ce5e..32edeea256ecb 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -545,12 +545,15 @@ if (LLAMA_VULKAN) endif() if (LLAMA_HIPBLAS) - if ($ENV{ROCM_PATH}) - set(ROCM_PATH $ENV{ROCM_PATH}) - else() - set(ROCM_PATH /opt/rocm) + if (NOT EXISTS $ENV{ROCM_PATH}) + if (NOT EXISTS /opt/rocm) + set(ROCM_PATH /usr) + else() + set(ROCM_PATH /opt/rocm) + endif() endif() list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH}) + list(APPEND CMAKE_PREFIX_PATH "$ENV{ROCM_PATH}/lib64/cmake") # CMake on Windows doesn't support the HIP language yet if(WIN32) From c90580438d276a6babba3ece46b2a63fcc65d78c Mon Sep 17 00:00:00 2001 From: Daniele <57776841+daniandtheweb@users.noreply.github.com> Date: Sun, 2 Jun 2024 16:43:39 +0000 Subject: [PATCH 2/2] Set ROCM_PATH correctly --- CMakeLists.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 32edeea256ecb..cb7b96a6d1ad4 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -551,9 +551,11 @@ if (LLAMA_HIPBLAS) else() set(ROCM_PATH /opt/rocm) endif() + else() + set(ROCM_PATH $ENV{ROCM_PATH}) endif() list(APPEND CMAKE_PREFIX_PATH ${ROCM_PATH}) - list(APPEND CMAKE_PREFIX_PATH "$ENV{ROCM_PATH}/lib64/cmake") + list(APPEND CMAKE_PREFIX_PATH "${ROCM_PATH}/lib64/cmake") # CMake on Windows doesn't support the HIP language yet if(WIN32)