Fix gemma model conversion #7992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm I solved that by commenting a line in gguf writer... alternatively, I could take the first one. |
|
about the hoops: a single click on huggingface doesn't seem much of a hoop. |
|
@0wwafa there aren't 2 chat templates, it's just being set twice accidentally because 2 places do it, and Gemma happens to be the only one that's calling both of those places |
|
Gemma 2 models were just released on HF. Trying to convert gemma-2-9b-it results in: |
|
See #8156 |
|
This is no longer a problem on |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7964
Untested, since I cannot download gemma without going through license hoops.
@0wwafa Would you mind giving it a try?